Remove assert from pv beamline peak.

This MR removes an assert assert(rising == false); that was in algorithm pv beamline peak.

This assert was raising running with option file https://gitlab.cern.ch/lhcb/Moore/-/blob/kmattiol_SMOG2/Hlt/Hlt1Conf/options/hlt1_smog_example.py under a stack compiled with x86_64_v3-centos7-clang12-dbg.

The logic preceding the assert seemingly does not require that rising is false, to be confirmed by @freiss .

assigned to @dcampora

requested review from @freiss

assigned to @freiss and unassigned @dcampora

It would be better to replace the assert with a meaningful one, I let you take over @freiss

added RTA label

I agree that this assert does not seem necessary. If I remember well it should warn against cases where there might be a peak at the edge of the histogram/proto cluster. But I agree that it shouldn't result in a hard failure

approved this merge request

added only GitLab CI label

Since a single assert has been removed, there is no need to run any tests for this MR.

merged

mentioned in commit 1811cdeb

mentioned in issue Moore#456 (closed)