Skip to content
Snippets Groups Projects
Da Yu Tou's avatar
commented on merge request !1972 "Point to new BuSca ParamFile." at LHCb / Allen

OK, I leave the rest to you. Thanks!

Miroslav Saur's avatar
commented on merge request !1972 "Point to new BuSca ParamFile." at LHCb / Allen

Now it is rather late for ci-test and I don't want to clash with night nightlies. Will test it locally in the morning, then would merge ParamFiles!...

Da Yu Tou's avatar
commented on merge request !1972 "Point to new BuSca ParamFile." at LHCb / Allen

@msaur Allen-ci should crash because the master branch of ParamFile do not have the fix. Can you just launch a ci-test (or test locally) regardless?

Da Yu Tou's avatar
opened merge request !1972 "Point to new BuSca ParamFile." at LHCb / Allen
Da Yu Tou's avatar
pushed new branch fix_busca at LHCb / Allen
Christopher Rob Jones's avatar
commented on merge request !1698 "Draft: Add pixel reconstruction to Rich" at LHCb / Allen

please default init to nullptr

Christopher Rob Jones's avatar
commented on merge request !1698 "Draft: Add pixel reconstruction to Rich" at LHCb / Allen

given richValue can only ever be one value its a bit untidy that you need to define both Allen::Rich1* and Allen::Rich2* but only ever initialise a...

Christopher Rob Jones's avatar
commented on merge request !1698 "Draft: Add pixel reconstruction to Rich" at LHCb / Allen

You would not know this but this 'region override' is a but of a hack in the CPU side to support the upgrade 2 studies. Its fine its here but it pr...

Christopher Rob Jones's avatar
commented on merge request !1698 "Draft: Add pixel reconstruction to Rich" at LHCb / Allen

everything here also should be default initalised...

Christopher Rob Jones's avatar
commented on merge request !1698 "Draft: Add pixel reconstruction to Rich" at LHCb / Allen

values should all have default initialisations here.

Christopher Rob Jones's avatar
commented on merge request !1698 "Draft: Add pixel reconstruction to Rich" at LHCb / Allen

please default initalise pointers to nullptr

Jiahui Zhuo's avatar
commented on merge request !1967 "Remove charge dependency in NN ghost killer" at LHCb / Allen

Yes, I would say small differences in efficiency and ghost rate is expected 😉

Miroslav Saur's avatar
pushed to branch master at LHCb / Allen
Miroslav Saur's avatar
deleted branch kalman_cpu at LHCb / Allen
Miroslav Saur's avatar
accepted merge request !1969 "Removed CPU codepath in Kalman Filter" at LHCb / Allen
Miroslav Saur's avatar
commented on merge request !1969 "Removed CPU codepath in Kalman Filter" at LHCb / Allen

Looks fine to me.

Arthur Marius Hennequin's avatar
approved merge request !1968 "Remove umesimd dependency" at LHCb / Allen
Arthur Marius Hennequin's avatar
pushed to branch ahennequ_magfield at LHCb / Allen
  • cec0809c · Fix CPU pragma unroll warnings, implement error in RK
Arthur Marius Hennequin's avatar
pushed to branch ahennequ_magfield at LHCb / Allen
Paras Naik's avatar
commented on merge request !1948 "ParKF: set pt limit on noise matrix scaling to fix Z-> ll Problem" at LHCb / Allen