Move functorcollections.py to DaVinci

Following the discussion in !898 (comment 5891207)

The functorcollections are actually tested with DaVinci test units, and some of the imported classes in functorcollections are defined in the upstream (DaVinci).

So maybe it's better to place functorcollections.py in DaVinci. This possibility should be considered thoroughly. We can discuss this after the DaVinci dependencies MR and clean-ups MR are done.

FYI: @amathad @erodrigu

added DPA-WP3 Tuples labels

mentioned in merge request !898 (merged)

changed title from Move the functorcollections.py to DaVinci to Move functorcollections.py to DaVinci

Hello @amathad and @pkoppenb, shall we then get back to this discussion since all "prerequisites" are now dealt with? I have no strong opinion :-).

Not sure. Functorcollections are closely bound to FunTuple. Now that DaVinci depends on Moore it's a bit academic. There's no clear distinction between Analysis and DaVinci.

Agreed.

In the functorcollections, for testing we are currently importing helper classes defined in DaVinci see example from DaVinciMCTools import MCReconstructed, MCReconstructible.

Feel like we are going to define more helper classes in DaVinci and if we want functorcollections to use them, we will have to do "fixes" like above.

mentioned in merge request !937 (merged)

mentioned in merge request !935 (merged)

This is very much linked to the #52 (closed). Closing.

closed