Draft: Fixed formatting
patch generated by https://gitlab.cern.ch/lhcb/Analysis/-/jobs/12101291
This branch contains two new Tuple Tools to be used in run2. The aim of those is to measure the number of prompt charged particles according to ALICE definition in gen MC and data. For data, it applies some correction stored in the /data directory.
Merge request reports
Activity
requested review from @masmith
assigned to @icorredo
mentioned in merge request !1039 (closed)
Hello. I was puzzled by this MR and had a brief look. Aside what @masmith says above, you should check carefully the contents: I see changes to the repository README for what seems like text for a private branch, ganga options, etc. Also the actual tools added do not contain a docstring carefully documenting what the tool is about and what variables it stores. These are all must-dos for things to get merge. It seems the cleanest would be to prepare a MR with only the tools. Else you need to remove a fair bit.
You should also add relevant labels as they are useful for bookkeeping.
Advance thanks.
Edited by Eduardo Rodrigues