Add new options to TupleToolDecayTreeFitter
Working with @shaines this MR adds a couple new options to TupleToolDecayTreeFitter
to fix some naming issues or add new features.
-
VetoPIDs
allows a list of PDG codes, which if found in the tree will be veto'ed from being filled. -
UseFullTreeInName
When set true this changes the logic that creates the branch name for each element in the tree, to include more of the ancestor history. The reason for this is the current logic fails in certain scenarios to distinguish between particles of the same type in the tree. The example we have isB -> ( D -> Ks pi pi ) Ks pi
where the old logic would not unambiguously identify the twoKs
particles.
The default for 1. is clearly an empty list. So no change in the default behaviour. The default for 2. is False, however, I think a case could be made that the current behaviour is wrong in certain cases, like the one above, and so True might be a better default.
Merge request reports
Activity
- [2017-07-29 00:03] Validation started with lhcb-old-stripping-tests#479
- [2017-07-29 00:08] Validation started with lhcb-head#1550
- [2017-07-29 00:08] Validation started with lhcb-gaudi-head-noavx#84
- [2017-07-29 00:08] Validation started with lhcb-gaudi-head-noavx2#65
- [2017-07-29 00:08] Validation started with lhcb-lcg-dev4#234
- [2017-07-29 00:08] Validation started with lhcb-clang-test#658
- [2017-07-29 00:08] Validation started with lhcb-lcg-dev3#234
- [2017-07-29 00:09] Validation started with lhcb-2017-patches#93
- [2017-07-29 00:10] Validation started with lhcb-gaudi-head#1547
- [2017-07-29 10:32] Validation started with lhcb-clang-test#658
- [2017-07-30 00:02] Validation started with lhcb-old-stripping-tests#480
- [2017-07-30 00:08] Validation started with lhcb-gaudi-head-noavx2#66
- [2017-07-30 00:08] Validation started with lhcb-2017-patches#94
- [2017-07-30 00:08] Validation started with lhcb-clang-test#659
- [2017-07-30 00:08] Validation started with lhcb-gaudi-head-noavx#85
- [2017-07-30 00:09] Validation started with lhcb-head#1551
- [2017-07-30 00:09] Validation started with lhcb-lcg-dev4#235
- [2017-07-30 00:10] Validation started with lhcb-gaudi-head#1548
- [2017-07-30 00:10] Validation started with lhcb-lcg-dev3#235
- [2017-07-30 08:09] Validation started with lhcb-gaudi-merge#178
- [2017-07-30 11:27] Validation started with lhcb-gaudi-merge#179
- [2017-07-30 15:32] Validation started with lhcb-gaudi-merge#180
- [2017-07-31 00:03] Validation started with lhcb-old-stripping-tests#481
- [2017-07-31 00:07] Validation started with lhcb-gaudi-head-noavx#86
- [2017-07-31 00:07] Validation started with lhcb-lcg-dev3#236
- [2017-07-31 00:07] Validation started with lhcb-gaudi-head-noavx2#67
- [2017-07-31 00:07] Validation started with lhcb-head#1552
- [2017-07-31 00:07] Validation started with lhcb-clang-test#660
- [2017-07-31 00:08] Validation started with lhcb-lcg-dev4#236
- [2017-07-31 00:09] Validation started with lhcb-2017-patches#95
- [2017-07-31 00:10] Validation started with lhcb-gaudi-head#1549
- [2017-07-31 10:54] Validation started with lhcb-gaudi-head#1550
- [2017-07-31 14:53] Validation started with lhcb-gaudi-merge#181
- [2017-07-31 15:02] Validation started with lhcb-gaudi-merge#181
- [2017-07-31 15:18] Validation started with lhcb-gaudi-merge#181
- [2017-08-01 13:48] Validation started with lhcb-gaudi-merge#182
- [2017-08-01 14:02] Validation started with lhcb-gaudi-merge#182
- [2017-08-01 14:23] Validation started with lhcb-gaudi-merge#182
- [2017-08-02 00:03] Validation started with lhcb-old-stripping-tests#483
- [2017-08-02 00:08] Validation started with lhcb-gaudi-head-noavx2#69
- [2017-08-02 00:08] Validation started with lhcb-gaudi-head-noavx#88
- [2017-08-02 00:08] Validation started with lhcb-head#1554
- [2017-08-02 00:08] Validation started with lhcb-lcg-dev4#238
- [2017-08-02 00:08] Validation started with lhcb-clang-test#662
- [2017-08-02 00:09] Validation started with lhcb-lcg-dev3#238
- [2017-08-02 00:09] Validation started with lhcb-2017-patches#97
- [2017-08-02 00:11] Validation started with lhcb-gaudi-head#1552
- [2017-08-02 09:34] Validation started with lhcb-gaudi-merge#183
- [2017-08-02 09:48] Validation started with lhcb-gaudi-merge#183
- [2017-08-02 10:02] Validation started with lhcb-gaudi-merge#183
- [2017-08-03 00:03] Validation started with lhcb-old-stripping-tests#484
- [2017-08-03 00:08] Validation started with lhcb-lcg-dev3#239
- [2017-08-03 00:08] Validation started with lhcb-gaudi-head-noavx2#70
- [2017-08-03 00:08] Validation started with lhcb-clang-test#663
- [2017-08-03 00:08] Validation started with lhcb-gaudi-head-noavx#89
- [2017-08-03 00:09] Validation started with lhcb-lcg-dev4#239
- [2017-08-03 00:10] Validation started with lhcb-2017-patches#98
- [2017-08-03 00:11] Validation started with lhcb-gaudi-head#1553
Edited by Software for LHCbadded 10 commits
-
d4ebd97d...df29afe2 - 8 commits from branch
master
- 2096faf6 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/Analysis into…
- 50c3fd22 - Add more safety checks to make sure branches do not change between candidates
-
d4ebd97d...df29afe2 - 8 commits from branch
- Resolved by Christopher Rob Jones
What do you think to my proposal of making the default for
UseFullTreeInName
True ? The only reason I did not just do it by default is because it does change the branch name for some entries in the tuple. The change is in a way that makes the decay history for each much more clear, but still as its a change we should discuss if it should be the default or not...I like the idea. Makes sense. I would be inclined to say that we wait for the full stack on master to be out, to the make the change. That's a 1-ish week delay. Would that be OK with you? As long as you write that down somewhere, not to forget, that should be fine. This way we still give a good version for users who do not want the change (in case). The settings have not changed for so long that we can afford a tiny delay. But again, I think your suggestion is good and should be made default.
mentioned in commit 1fda9da0