Input to PrintDecayTree

Change of input for PrintDecayTree: take vector of particles, which is what Hlt2 algorithms return rather than LHCb::Particles, the KeyedContainer.

This may not be needed if @apearce changes the output type of Hlt2 algorithms. Hence WIP.

Now no longer take vector.

added lhcb-run3-cleanup label

mentioned in merge request DaVinci!538 (merged)

• [2021-04-30 18:14] Validation started with lhcb-master-mr#2266
• [2021-05-01 01:29] Validation started with lhcb-run3-cleanup#200
• [2021-05-04 00:32] Validation started with lhcb-run3-cleanup#201
• [2021-05-05 00:10] Validation started with lhcb-gaudi-head#2920
• [2021-05-05 00:13] Validation started with lhcb-head#2935
• [2021-05-05 00:15] Validation started with lhcb-head-2#234
• [2021-05-05 00:17] Validation started with lhcb-lcg-dev4#1636
• [2021-05-05 00:17] Validation started with lhcb-lcg-dev3#1621
• [2021-05-05 00:23] Validation started with lhcb-lcg-test#177
• [2021-05-05 00:55] Validation started with lhcb-run3-cleanup#202
• [2021-05-05 01:19] Validation started with lhcb-head#2935
• [2021-05-05 01:24] Validation started with lhcb-sanitizers#850
• [2021-05-05 12:16] Validation started with lhcb-head#2936
• [2021-05-06 00:09] Validation started with lhcb-gaudi-head#2921
• [2021-05-06 00:15] Validation started with lhcb-head-2#235
• [2021-05-06 00:15] Validation started with lhcb-head#2937
• [2021-05-06 00:15] Validation started with lhcb-lcg-dev4#1637
• [2021-05-06 00:16] Validation started with lhcb-lcg-dev3#1622
• [2021-05-06 00:18] Validation started with lhcb-lcg-test#178
• [2021-05-06 00:49] Validation started with lhcb-run3-cleanup#203
• [2021-05-06 00:49] Validation started with lhcb-sanitizers#851
• [2021-05-06 01:17] Validation started with lhcb-head#2937
• [2021-05-06 10:49] Validation started with lhcb-head#2938
• [2021-05-07 00:09] Validation started with lhcb-gaudi-head#2922
• [2021-05-07 00:17] Validation started with lhcb-head-2#236
• [2021-05-07 00:18] Validation started with lhcb-head#2939
• [2021-05-07 00:33] Validation started with lhcb-lcg-dev3#1623
• [2021-05-07 00:37] Validation started with lhcb-lcg-dev4#1638
• [2021-05-07 00:40] Validation started with lhcb-lcg-test#179
• [2021-05-07 00:53] Validation started with lhcb-run3-cleanup#204
• [2021-05-07 01:01] Validation started with lhcb-sanitizers#852
• [2021-05-07 01:08] Validation started with lhcb-gaudi-head#2922
• [2021-05-08 00:11] Validation started with lhcb-gaudi-head#2923
• [2021-05-08 00:19] Validation started with lhcb-head-2#237
• [2021-05-08 00:24] Validation started with lhcb-head#2940
• [2021-05-08 00:38] Validation started with lhcb-lcg-dev3#1624
• [2021-05-08 00:40] Validation started with lhcb-lcg-dev4#1639
• [2021-05-08 00:45] Validation started with lhcb-lcg-test#180
• [2021-05-08 01:05] Validation started with lhcb-sanitizers#853
• [2021-05-08 01:11] Validation started with lhcb-run3-cleanup#205
• [2021-05-08 01:14] Validation started with lhcb-head-2#237
• [2021-05-09 00:08] Validation started with lhcb-gaudi-head#2924
• [2021-05-09 00:12] Validation started with lhcb-lcg-dev3#1625
• [2021-05-09 00:13] Validation started with lhcb-lcg-dev4#1640
• [2021-05-10 00:10] Validation started with lhcb-lcg-dev3#1626
• [2021-05-10 00:11] Validation started with lhcb-lcg-dev4#1641
• [2021-05-10 00:14] Validation started with lhcb-run3-cleanup#206
• [2021-05-11 00:08] Validation started with lhcb-gaudi-head#2925
• [2021-05-11 00:14] Validation started with lhcb-head-2#238
• [2021-05-11 00:14] Validation started with lhcb-head#2941
• [2021-05-11 00:17] Validation started with lhcb-lcg-dev3#1627
• [2021-05-11 00:18] Validation started with lhcb-lcg-dev4#1642
• [2021-05-11 00:27] Validation started with lhcb-lcg-test#181
• [2021-05-11 00:41] Validation started with lhcb-sanitizers#854
• [2021-05-11 00:44] Validation started with lhcb-run3-cleanup#207
• [2021-05-12 00:11] Validation started with lhcb-gaudi-head#2926
• [2021-05-12 00:18] Validation started with lhcb-head-2#239
• [2021-05-12 00:23] Validation started with lhcb-head#2942
• [2021-05-12 00:27] Validation started with lhcb-lcg-dev3#1628
• [2021-05-12 00:44] Validation started with lhcb-lcg-dev4#1643
• [2021-05-12 00:55] Validation started with lhcb-lcg-test#182
• [2021-05-12 01:05] Validation started with lhcb-run3-cleanup#208
• [2021-05-12 01:06] Validation started with lhcb-sanitizers#855
• [2021-05-12 01:22] Validation started with lhcb-head-2#239
• [2021-05-12 13:56] Validation started with lhcb-master-mr#2305
• [2021-05-12 16:49] Validation started with lhcb-lcg-test#183
• [2021-05-13 00:13] Validation started with lhcb-gaudi-head#2927
• [2021-05-13 00:23] Validation started with lhcb-head-2#240
• [2021-05-13 00:25] Validation started with lhcb-head#2943
• [2021-05-13 00:30] Validation started with lhcb-lcg-dev3#1629
• [2021-05-13 00:42] Validation started with lhcb-lcg-dev4#1644
• [2021-05-13 01:00] Validation started with lhcb-lcg-test#184
• [2021-05-13 01:02] Validation started with lhcb-run3-cleanup#209
• [2021-05-13 01:04] Validation started with lhcb-sanitizers#856
• [2021-05-13 01:21] Validation started with lhcb-head-2#240
• [2021-05-13 01:23] Validation started with lhcb-head#2943
• [2021-05-14 00:19] Validation started with lhcb-lcg-dev4#1645
• [2021-05-14 01:15] Validation started with lhcb-run3-cleanup#210
• [2021-05-14 01:32] Validation started with lhcb-gaudi-head#2928
• [2021-05-14 01:40] Validation started with lhcb-sanitizers#857
• [2021-05-14 01:56] Validation started with lhcb-lcg-test#185
• [2021-05-15 00:08] Validation started with lhcb-gaudi-head#2929
• [2021-05-15 00:16] Validation started with lhcb-head-2#242
• [2021-05-15 00:23] Validation started with lhcb-lcg-dev3#1631
• [2021-05-15 00:24] Validation started with lhcb-lcg-dev4#1646
• [2021-05-15 00:48] Validation started with lhcb-gaudi-head#2929
• [2021-05-16 00:09] Validation started with lhcb-gaudi-head#2930
• [2021-05-16 00:12] Validation started with lhcb-head-2#243
• [2021-05-16 00:12] Validation started with lhcb-head#2945
• [2021-05-16 00:13] Validation started with lhcb-lcg-dev3#1632
• [2021-05-16 00:14] Validation started with lhcb-lcg-dev4#1647
• [2021-05-16 00:16] Validation started with lhcb-lcg-test#186
• [2021-05-16 00:31] Validation started with lhcb-run3-cleanup#211
• [2021-05-16 00:38] Validation started with lhcb-sanitizers#858
• [2021-05-16 00:51] Validation started with lhcb-sanitizers#858
• [2021-05-17 00:10] Validation started with lhcb-lcg-dev3#1633
• [2021-05-17 00:10] Validation started with lhcb-lcg-dev4#1648
• [2021-05-18 01:10] Validation started with lhcb-run3-cleanup#212
• [2021-05-19 01:00] Validation started with lhcb-run3-cleanup#213
• [2021-05-20 01:10] Validation started with lhcb-run3-cleanup#214
• [2021-05-21 01:24] Validation started with lhcb-run3-cleanup#215
• [2021-05-22 01:26] Validation started with lhcb-run3-cleanup#216
• [2021-05-25 00:46] Validation started with lhcb-run3-cleanup#217
• [2021-05-26 01:20] Validation started with lhcb-run3-cleanup#218
• [2021-05-26 13:37] Validation started with lhcb-master-mr#2374

added 1 commit

• 65cacc5b - Make particle scounter work

Compare with previous version

added 1 commit

• bedc01b6 - Update Phys/DaVinciTools/src/PrintDecayTree.cpp

Compare with previous version

marked this merge request as ready

added all-slots label

Just a thought - rather than making a replacement of one (input) signature to another, would it be good and possible to template or have several possibles inputs, to deal with various types of "containers"? Maybe Gerhard can help us here?

This may not be needed if @apearce changes the output type of Hlt2 algorithms.

I've opened Phys!933 (merged) with most of the major changes.

I agree with @erodrigu that templating the algorithm might be useful given that there are a couple of input types one can imagine feeding in. During my work I noticed that lots of algorithms take LHCb::Particle::Range as input, which allows them to accept KeyedContainer and SharedObjectContainer; we produce both of these types in Moore so having algorithms which accept Range is useful as one doesn't have to explicitly instantiate algorithms for both types.

mentioned in merge request DaVinci!539 (merged)

added DPA-WP3 label

/ci-test --merge DaVinci!538 (merged)

Just checking if this MR can live on its own now (with DaVinci!538 (merged))

added ci-test-triggered label

Doesn't work. It needs more MRs to be merged simultaneously. So let's wait.

@pkoppenb is the label all-slots still required for this MR?
It's currently breaking a few DaVinci tests in all nigtly slots.

removed all-slots label

OK. Let's remove. It's building on lhcb-run3-cleanup anyway.

/ci-test --merge DaVinci!538 (merged)

Does it work if you use LHCb::Particle::Range rather than std::vector<LHCb::Particle>? The former should allow the algorithm to accept several different container types.