added protection against photons in TTIsoGeneric

The tool should ignore neutrals particles in the decay, for calculating isolations around charged tracks.

The pipeline needs fixing

added Tuples all-slots legacy labels

There is some formatting problem. Running
curl https://gitlab.cern.ch/lhcb/Analysis/-/jobs/18711559/artifacts/raw/apply-formatting.patch | git am
I get
error: patch failed: Phys/DecayTreeTuple/src/TupleToolIsoGeneric.cpp:112 error: Phys/DecayTreeTuple/src/TupleToolIsoGeneric.cpp: patch does not apply Patch failed at 0001 Fixed formatting hint: Use 'git am --show-current-patch=diff' to see the failed patch Then...

   bool              test   = true;
   if ( !P ) { return StatusCode( test ); }
 
-  if ( isPureNeutralCalo( P )    ) return StatusCode(test); // added by Biplab to protect againt photons
+  if ( isPureNeutralCalo( P ) ) return StatusCode( test ); // added by Biplab to protect againt photons
   if ( !( P->isBasicParticle() ) ) return StatusCode( test );
   if ( mother->isBasicParticle() ) return StatusCode( test );

What should I change?

• [2022-01-12 00:39] Validation started with lhcb-run2-gaudi-head#258
• [2022-01-12 00:41] Validation started with lhcb-run2-patches-dev4#934
• [2022-01-12 00:43] Validation started with lhcb-run2-patches#1078
• [2022-01-13 00:50] Validation started with lhcb-run2-gaudi-head#259
• [2022-01-13 00:56] Validation started with lhcb-run2-patches-dev4#935
• [2022-01-13 00:58] Validation started with lhcb-run2-patches#1079
• [2022-01-14 00:49] Validation started with lhcb-run2-patches-dev4#936
• [2022-01-14 00:52] Validation started with lhcb-run2-gaudi-head#260
• [2022-01-14 00:55] Validation started with lhcb-run2-patches#1080
• [2022-01-15 00:52] Validation started with lhcb-run2-gaudi-head#261
• [2022-01-15 00:59] Validation started with lhcb-run2-patches-dev4#937
• [2022-01-15 01:00] Validation started with lhcb-run2-patches#1081
• [2022-01-15 01:20] Validation started with lhcb-run2-patches#1081
• [2022-01-16 00:08] Validation started with lhcb-run2-patches-dev4#938
• [2022-01-17 00:08] Validation started with lhcb-run2-patches-dev4#939
• [2022-01-18 00:20] Validation started with lhcb-run2-patches-dev4#940
• [2022-01-19 00:41] Validation started with lhcb-run2-gaudi-head#262
• [2022-01-19 00:44] Validation started with lhcb-run2-patches-dev4#941
• [2022-01-19 00:44] Validation started with lhcb-run2-patches#1082
• [2022-01-21 00:34] Validation started with lhcb-run2-gaudi-head#264
• [2022-01-21 00:34] Validation started with lhcb-run2-patches-dev4#943
• [2022-01-21 00:35] Validation started with lhcb-run2-patches#1084
• [2022-01-22 00:44] Validation started with lhcb-run2-gaudi-head#265
• [2022-01-22 00:47] Validation started with lhcb-run2-patches-dev4#944
• [2022-01-22 00:51] Validation started with lhcb-run2-patches#1085
• [2022-01-23 00:08] Validation started with lhcb-run2-patches-dev4#945
• [2022-01-24 00:10] Validation started with lhcb-run2-patches-dev4#946
• [2022-01-24 00:10] Validation started with lhcb-run2-patches#1086
• [2022-01-24 00:10] Validation started with lhcb-run2-gaudi-head#266

mentioned in merge request !854 (merged)

There are some formatting issues.

I tried skipping the patch, but then there is nothing to push. How do I resolve the formatting?

added 1 commit

• e2f07221 - Fixed formatting

Compare with previous version

Thanks! What did I need to do, for my understanding? This formatting issue comes up often.

You just need to git push origin after the fixed formatting. Although if you are using lb-dev to have checked it out I think that only allows for one push, so you would need to clone the package.

closed

reopened

We'll put this and the other through the nightlies

resolved all threads

mentioned in commit 38907eb7

merged