Phys/DaVinciTrackScaler:Momentum scaling: take run number from ODIN
Momentum scaling: take run number from ODIN
Merge request reports
Activity
For reference: this MR was created due to the discussion in the thread "Usage of TrackScaleState for Turbo stream" on
lhcb-davinci
andlhcb-trigger-software
.In that thread, @ibelyaev said that the
/Event/DAQ
node is killed whenDaVinci().RootInTES
is set, as is usually done when running over µDSTs. Does that mean this patch won't work for µDSTs? If so, we could try one location first and fall back to another on failure?I had a very brief look to try to find where the change was from, from the ODIN location to
Rec/Header
, but couldn't find it.Can I ask how it can work for µDSTS, if what you say is true that the
/Event/DAQ
location is normally killed whenRootInTES
andInputType
are set correctly?If
LHCb::ODINLocation::Default
is/Event/DAQ/ODIN
, and/Event/DAQ
is killed, I'd have thought the request for the location would fail.I don't doubt your tests work, and I will try them soon, but I don't understand why given your explanation. (Sorry for being slow.)
Turbo files only have
/Event/DAQ/ODIN
, no/Event/Turbo/DAQ/ODIN
(there's no/Event/Turbo/DAQ
at all). So if/Event/DAQ
is always killed by the µDST node killer, and then/Event/Turbo/DAQ
is linked to to/Event/DAQ
,/Event/DAQ/ODIN
won't exist, because/Event/DAQ/ODIN
doesn't exist.I'm testing this with a 2016 Turbo file:
/lhcb/LHCb/Collision16/CHARMTWOBODY.MDST/00053760/0000/00053760_00000706_1.charmtwobody.mdst
Ah OK I see; with
/Event/DAQ
only killed for non-Turbo files this fix makes a lot more sense. Thanks for your patience😄 In which case, this MR looks good to me
👍
The streams are defined in
TurboStreamProd.streams
.Edited by Alex PearceMentioned in commit d09b23c6