Skip to content
Snippets Groups Projects

FunTuple - API changes and simplification of Python helper modules

Merged Eduardo Rodrigues requested to merge erodrigu-funtuple-2 into master

Hi @amathad, I'm making a simplification here to avoid a packing-unpacking in what is anyway an internal function.

While at it I suggest the renaming tree_name -> tuple_name as I really hope we will move from TTree to RNTuple at some point. I realise this breaks the API and requires updates in DaVinci, but I would rather do it now than 2 months down the line. What do you think?

More details on the API changes in the related DaVinci MR DaVinci!652 (merged).

Edited by Eduardo Rodrigues

Merge request reports

Merge request pipeline #3550675 passed

Merge request pipeline passed for 707151f4

Merged by Patrick KoppenburgPatrick Koppenburg 3 years ago (Feb 10, 2022 2:00pm UTC)

Loading

Pipeline #3552406 passed

Pipeline passed for c0025b2a on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Patrick Koppenburg approved this merge request

    approved this merge request

  • Patrick Koppenburg resolved all threads

    resolved all threads

  • Edited by Software for LHCb
  • Patrick Koppenburg marked this merge request as draft

    marked this merge request as draft

  • Eduardo Rodrigues changed title from Draft: Simplify FunTuple Python helper modules to Draft: FunTuple - API changes and simplification of Python helper modules

    changed title from Draft: Simplify FunTuple Python helper modules to Draft: FunTuple - API changes and simplification of Python helper modules

  • added 1 commit

    • f2d6350e - Rename branch -> field having in mind RNTuple in the future!

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading