Fixes to functorcollections doc and add MCParticle.h to ThOr functor headers for truth matching

Includes some fixes to functorcollections doc. It also fixes MC association functor F.MAP_INPUT(F.P, MCAssocTable) which crashes when JIT compiling, since there is no MCParticle.h in the header for any functors involved, fixed by adding MCParticle.h to every functor that runs over LHCb::Particle::Range.

added DPA-WP3 Tuples labels

requested review from @erodrigu and @pkoppenb

assigned to @amathad

changed the description

/ci-test

added ci-test-triggered label

• [2022-03-13 13:55] Validation started with lhcb-master-mr#3957

changed the description

Question is why on earth was it compiling in the first instance e.g. in option_davinci_tupling_from_hlt2.py!

In-fact if I add a functor F.MAP_INPUT(F.ParticleID, MCAssocTable) before F.MAP_INPUT(F.P, MCAssocTable), where F.ParticleID does contain MCParticle.h header, it is completely fine.

Very strange behaviour of functors here...

Looking at the CI test result, could this actually address the random failings of option_davinci_tupling_from_hlt2.py (i.e. this issue? (FYI: @dfazzini)

approved this merge request

resolved all threads

resolved all threads

approved this merge request

merged

mentioned in commit 83a5f9d2

mentioned in merge request !878 (merged)

mentioned in issue DaVinci#41 (closed)