Updates to RICH: time gate simulation and monitoring for SIN.
Updates to RICH monitoring for signal-induced noise contribution.
Also includes changes needed for time gate simulation using detailed time information for all deposit types (including SIN and spillover).
Needs LHCb!2581 (merged).
Merge request reports
Activity
mentioned in merge request LHCb!2581 (merged)
@seaso @jonrob I've made some updates to include SIN into RICH digi monitoring (now it has it's dedicated history code and also does not give any warnings due to lack of associated hits anymore). Please let me know if you had some other updates to monitoring in mind (I mean any new plots / counters to include).
cc: @gcavalle
Hi @bmalecki, sorry to jump on this while it's still WIP. Since you mentioned monitoring histograms, it would be good to setup them in the LHCbPR/Boole dashboard. Beside this, can you give some additional information on the meaning of the TimeGateParam1,...,TimeGateParam4? A link to some documentation/talk in the code would be fine as well.
Hi @gcavalle, I don't know yet if this MR will add any histograms to the monitoring (SIN counters for sure). But anyway I'll have a look on what we could add to the LHCbPR from the current monitoring. BTW, is this a good reference on how to do that (https://indico.cern.ch/event/875987/contributions/3829449/subcontributions/304212/attachments/2024103/3385423/SimRTA.pdf)? Or maybe there is something more up to date?
As for the time gate parameters, those are mostly related to time gate range for each RICH. I'll add proper descriptions in this MR, which will also include updates to simulate time gate for all deposit types (i.e. including SIN and spillover).
added 1 commit
- c55f4e71 - Extend SIN simulation to any time window (fix).
added 2 commits
added 2 commits
added 29 commits
-
6fec740c...36fd479e - 15 commits from branch
master - 4a059ba0 - Valid gain provider (with some min value).
- 31b0fd1d - Provide SIN deposit info and apply time gate (dummy).
- 7d4588a1 - Set range of default 25 ns time gate.
- 2a0996e5 - Special case for SIN in RICH monitoring.
- 1ace74e1 - Add histogram with time of acquisition.
- 8b857d38 - Extend SIN simulation to any time window.
- 82563a57 - Provide basic output time-sampling
- 3b61fb6b - Cleanup some debugging info.
- a13c11af - Process signal deposits (time-sampling).
- 47c51d5a - Extend SIN simulation to any time window (fix).
- e758b50a - Process SIN deposits (time-sampling).
- 5926d0e8 - Provide a simple time gate.
- 0db43bc0 - Add a time-gate with the lookup table.
- 7efac0d5 - Cleanup the time-gate implementation.
Toggle commit list-
6fec740c...36fd479e - 15 commits from branch
@bmalecki Is this ready to be reviewed and merged yet ? It would be good to not leave it pending as WIP for too long, as e.g. I want to start work on some updates for a realistic DAQ format, and it would be good to merge this soon to avoid potential dial conflicts.
@jonrob The time-gate implementation is basically ready. There are a two other things that need updating here:
- processsing each deposit in a channel in the same way (now we use summedDeposit, which makes an issue e.g. for the spillover hits)
- monitoring histograms
This is close to be ready, I hope to have at least the deposit processing by the end of this week ready for the review.