Remove L0 from Calo digitisation

Remove L0 from Calo digitisation. Necessary following LHCb!2735 (merged). Some L0-related SPD/PRS functionality removed from CaloPinDigitAlg.

It is not clear to me whether CaloDigitAlg still does something useful. To be revised by Calo experts.

In addition, .gitignore is updated (by copying it from LHCb) and tests use a unique DatasetName to avoid problems when running them in parallel.

added cleanup label

mentioned in merge request LHCb!2736 (merged)

• [2020-09-03 00:14] Validation started with lhcb-run3-cleanup#4
• [2020-09-04 00:09] Validation started with lhcb-run3-cleanup#5
• [2020-09-05 00:12] Validation started with lhcb-run3-cleanup#6
• [2020-09-06 00:08] Validation started with lhcb-run3-cleanup#7
• [2020-09-08 00:08] Validation started with lhcb-run3-cleanup#8
• [2020-09-09 00:16] Validation started with lhcb-run3-cleanup#9
• [2020-09-10 00:08] Validation started with lhcb-run3-cleanup#10
• [2020-09-11 00:11] Validation started with lhcb-run3-cleanup#11
• [2020-09-12 00:11] Validation started with lhcb-run3-cleanup#12
• [2020-09-14 00:11] Validation started with lhcb-run3-cleanup#13
• [2020-09-15 00:52] Validation started with lhcb-run3-cleanup#14
• [2020-09-16 00:09] Validation started with lhcb-run3-cleanup#15
• [2020-09-17 00:12] Validation started with lhcb-run3-cleanup#16
• [2020-09-18 00:09] Validation started with lhcb-run3-cleanup#17
• [2020-09-19 00:12] Validation started with lhcb-run3-cleanup#18
• [2020-09-22 00:22] Validation started with lhcb-run3-cleanup#19
• [2020-09-23 00:13] Validation started with lhcb-run3-cleanup#20
• [2020-09-24 00:09] Validation started with lhcb-run3-cleanup#21
• [2020-09-25 00:08] Validation started with lhcb-run3-cleanup#22
• [2020-09-26 00:08] Validation started with lhcb-run3-cleanup#23
• [2020-09-27 00:07] Validation started with lhcb-run3-cleanup#24
• [2020-09-28 00:07] Validation started with lhcb-run3-cleanup#25
• [2020-09-29 00:13] Validation started with lhcb-run3-cleanup#26
• [2020-10-01 00:07] Validation started with lhcb-run3-cleanup#27
• [2020-10-02 00:13] Validation started with lhcb-run3-cleanup#28
• [2020-10-03 00:08] Validation started with lhcb-run3-cleanup#29
• [2020-10-04 00:08] Validation started with lhcb-run3-cleanup#30
• [2020-10-05 00:08] Validation started with lhcb-run3-cleanup#31

added 1 commit

• 7408ab19 - Remove L0 remnants and comment out SPD/PRS

Compare with previous version

Further hacked CaloPinDigitAlg

assigned to @deschamp

mentioned in merge request !308 (closed)

@jmarchan can you please have a look?

I just had a look to lhcb-run3-cleanup#15 and it looks like there are some counter mismatch and many errors linked to CaloEnergyFromRaw: https://lhcb-nightlies.web.cern.ch/logs/tests/nightly/lhcb-run3-cleanup/15/x86_64-centos7-gcc9-opt/Boole/#all_3

Also DAQSys shows an error: https://lhcb-nightlies.web.cern.ch/logs/tests/nightly/lhcb-run3-cleanup/15/x86_64-centos7-gcc9-opt/LHCb/#all_379 KeyError: 'Raw/Spd/Digits is not configured'

I'm not sure I see the link with L0 changes, it's probably linked to other changes, do you expect this @pkoppenb ?

Hi @jmarchan. Thanks for jumping in . It's a pity I couldn't connect to yesterday's calo meeting. I was thrown into another meeting by Nikhef management :(

The Spd/Digits error is related to the removal of SPD, which I already did in some parts and will complete in the next couple of weeks. I'm mostly interested in the consequences for physics, so if that could be done by a calo expert, or in close connection with a calo expert, that would be very useful.

The errors I am worried about are those of type

• EcalAdcFromRaw.... ERROR CaloEnergyFromRaw:: FE-Card w/ [code : 106 ] is not associated with TELL1 bank sourceID : 0 in condDB : Cannot read that bank StatusCode=FAILURE
• EcalAdcFromRaw.... ERROR CaloEnergyFromRaw:: Warning : previous data may be corrupted StatusCode=FAILURE

because I obviously screwed up something here.

I was trying to understand this one, to what I see CaloEnergyFromRaw hasn't been modified in your MR. I already had this kind of error in the past when using wrong DB, not sure it can be the case here?

There is this MR !299 (merged) but also changes in LHCb

To get things to run from this nightly you need to do

set build = 15 cd ~/workspace (or wherever) lbn-install lhcb-run3-cleanup/$build

takes 15 minutes

lb-dev --nightly-base ~/workspace --nightly lhcb-run3-cleanup/$build -c x86_64-centos7-gcc9-opt --name Boole_cleanup Boole/HEAD

Needs to be merged together with LHCb!2735 (merged) and LHCb!2736 (merged). cc @rmatev

See also discussions at https://gitlab.cern.ch/lhcb-dpa/project/-/issues/37

mentioned in issue Moore#212 (closed)

mentioned in issue Moore#213 (closed)

assigned to @rmatev

@jmarchan committed a fix in LHCb LHCb!2736 (merged) . Let's see how that behaves in the nighlties.

All lhcb-run3-cleanup tests pass today. Can this be merged, @cattanem or do we wait for PAC as with !308 (closed) ?

mentioned in merge request LHCb!2735 (merged)

added 15 commits

• 7408ab19...e7d9147f - 10 commits from branch master
• 7650a8f0 - Remove L0 from Calo digitisation
• 33b059e4 - Remove L0 remnants and some SPD/PRS code
• c25e1f45 - Fix references for tests following removal of L0
• e4ffab41 - Add .gitignore from LHCb/master
• 0d92c544 - Use unique DatasetName per test (solves race condtion)

Compare with previous version

changed the description

added Calo label

unassigned @jmarchan and @deschamp

added lhcb-head label

• [2020-10-06 00:07] Validation started with lhcb-run3-cleanup#32
• [2020-10-06 00:13] Validation started with lhcb-head#2730

This worked well in lhcb-head#2730, so it is ready to be merged. After that LHCb!2735 (merged) can follow.

FYI @raaij @ascarabo

assigned to @gcavalle and @cattanem and unassigned @rmatev

removed lhcb-head label

resolved all threads

mentioned in commit 7a278fcc

merged

mentioned in merge request !311 (merged)

added DPA-WP3 label