SciFi simulation effective noise model

Could you please squash the commits into a small meaningful set of commits?

changed the description

added 19 commits

caea59a9 - Remove unnecessary dependency on obsolete detectors
0fc0fca0 - FTClusterTuple update, add FTLiteClusterTuple
144a8ca0 - dirty first draft of effective noise
e118cc6e - update xtalk delay and DCR scaling
b3245afd - fix whitespace and add noisedata
c340884f - update dark noise model
3553a581 - update eff noise function parameters
5ba24509 - add const
0730d535 - Follow LHCb changes -- cleanup UT
27fd1177 - New UT Encoder for TELL40 data format
45867d3a - Release notes and dependencies for v41r3
ea156480 - add const
727722ad - Clean lines removed by the preprocessing
d78e15b8 - Update references for LHCb!2914 (merged)
ba69441e - follow changes in LHCb!2956 (merged)
4aedeb02 - changes required for LHCb!2959 (merged)
ad02ca8a - Update electronics function and hittype branch
6ddb8cf8 - Electronics response spillover added
37e4c722 - Remove doubly defined parameters effective noise

Hi @emgabrie, while for the purpose of testing this MR it's good to have the numbers you provide in src/effnoisedata and in the csv files (and it's ok for the time being), can you please consider to move them to SIMCOND? It would also be better to move the values provided in SiPMResponse.cpp to SIMCOND if it's suitable for you.

Is the default of the electronics response set to pacific5_pz5 ok for all the modules, or do you plan to have different responses for different modules?

I've added the lhcb-head label so we can have a look to the changes introduced by this MR to the available distributions in the LHCbPR integration tests.

[2021-04-20 00:22] Validation started with lhcb-head#2921
[2021-05-07 00:15] Validation started with lhcb-head#2939
[2021-05-08 00:19] Validation started with lhcb-head#2940
[2021-05-11 00:11] Validation started with lhcb-head#2941
[2021-05-12 00:18] Validation started with lhcb-head#2942
[2021-05-13 00:20] Validation started with lhcb-head#2943
[2021-05-13 01:20] Validation started with lhcb-head#2943
[2021-05-14 00:15] Validation started with lhcb-head#2944
[2021-05-16 00:10] Validation started with lhcb-head#2945
[2021-05-18 00:16] Validation started with lhcb-head#2946

Hi @emgabrie the tests failed with a crash (likely from the initialise() of the FTSiPMTool). You can click on the link above to access the full logs. Can you please investigate?

removed lhcb-head label

Hi @gcavalle, I will have a look, thanks. Regarding moving the effnoisedata and maybe the sipmresponse to SIMCOND, we will discuss this in the SciFi simulation group and I'll get back to you.

added 1 commit

37e8e627 - remove faulty electronics spillover

Compare with previous version

Hi @gcavalle, I cannot reproduce this error locally on my branch so I am not sure how to debug..

Hi @emgabrie the problem is likely due to the relative path FT/FTDigitisation/src/effnoisedata/ used to read the files such as pacific5q_pz5_T1.5_2.5_4.5_G1.5.txt.

When running inside the Boole directory the tests run ok, but they don't if you run them from another place.

I would suggest to move these files to SIMCOND or, as a temporary solution to test this MR, to copy these values as done for the time shifts (I believe) in SiPMResponse.cpp

added 1 commit

6ead5199 - effective noise data moved to FTSiPMTool.cpp

Compare with previous version

Hi @gcavalle, this should be fixed now. (sidenote: the current code simulates NO noise if the effective noise parameters do not exist. As this is a temporary solution I left it like this for now.)