Skip to content
Snippets Groups Projects

Clean up tests and update sample/tags

Merged Clean up tests and update sample/tags
rm-update-tests into master
All threads resolved!
Merged Rosen Matev requested to merge rm-update-tests into master
All threads resolved!

Behaviour changes:

  • Remove extra VP (superpixel) banks when writing MDF data

Test cleanups and improvements

  • Update tests to use a recent sim sample and tags (see LHCBGAUSS-2635)
  • Remove redundant Rich-RealDataFormat test
  • Reduce number of events used for dump-vp-rawbank test
  • Replace xdigi reprocessing test with two tests (first produce, then reprocess)
  • Remove boolesys test (subset of boole-upgrade-baseline)
  • Remove xdst tests (to be restored when we can produce dsts)
  • Remove obsolete VPRetinaCluster tests (now default behaviour)
  • Add tests to dump and check raw data (e.g. source ID conformance to Online specs)
  • Update references

Needs lhcb-datapkg/PRConfig!254 (merged)

/cc @edelucia @gcavalle @gcorti @kreps @cattanem @jonrob

Edited by Rosen Matev

Merge request reports

Merge request pipeline #4472039 passed

Stage: test
    Stage: .post

      Merge request pipeline passed for b1532cac

      Approval is optional

      Merged by Rosen MatevRosen Matev 2 years ago (Sep 12, 2022 7:26am UTC)

      Merge details

      • Changes merged into master with 8bac9aa4 (commits were squashed).
      • Deleted the source branch.

      • Mentions issue LHCBGAUSS-2635

      Pipeline #4479941 passed

      Stage: test

        Pipeline passed for 8bac9aa4 on master

        Activity

        Filter activity
        • Approvals
        • Assignees & reviewers
        • Comments (from bots)
        • Comments (from users)
        • Commits & branches
        • Edits
        • Labels
        • Lock status
        • Mentions
        • Merge request status
        • Tracking
      • Giovanni Cavallero mentioned in merge request !335 (merged)

        mentioned in merge request !335 (merged)

      • Rosen Matev added 1 commit

        added 1 commit

        • be148d2c - Clean up tests and update sample/tags

        Compare with previous version

      • Rosen Matev resolved all threads

        resolved all threads

      • Rosen Matev resolved all threads

        resolved all threads

      • Rosen Matev added 1 commit

        added 1 commit

        • 5c72caae - Clean up tests and update sample/tags

        Compare with previous version

      • Rosen Matev assigned to @rmatev

        assigned to @rmatev

      • Rosen Matev changed the description

        changed the description

      • Rosen Matev added 4 commits

        added 4 commits

        • d6cebd58 - Clean up tests and update sample/tags
        • 3aae0ac3 - Add tests to dump and check raw data
        • f8f9e468 - Remove obsolete VPRetinaCluster tests (now default behaviour)
        • b1532cac - Remove extra VP (superpixel) banks in MDF data

        Compare with previous version

        Toggle commit list
      • Rosen Matev mentioned in issue LHCb#202

        mentioned in issue LHCb#202

      • Rosen Matev
      • Rosen Matev changed the description

        changed the description

      • Rosen Matev mentioned in issue #11 (closed)

        mentioned in issue #11 (closed)

      • Rosen Matev resolved all threads

        resolved all threads

      • Rosen Matev mentioned in commit 8bac9aa4

        mentioned in commit 8bac9aa4

      • Rosen Matev merged

        merged

      • Marco Cattaneo
        Marco Cattaneo @cattanem started a thread on commit 3aae0ac3
        • Digi/Boole/tests/qmtest/boole.qms/boole-dump-vp-rawbank.qmt → Digi/Boole/tests/qmtest/boole.qms/boole-dump-raw.qmt
        40
        41 try:
        42 os.remove("boole-dump-raw.stdout")
        43 except:
        44 pass
        45
        39 46 </text></argument>
        40 <argument name="reference"><text>../refs/boole-dump-vp-rawbank.ref</text></argument>
        47 <argument name="reference"><text>../refs/boole-dump-raw.ref</text></argument>
        41 48 <argument name="validator"><text>
        42 from Boole.QMTest.BooleExclusions import preprocessor as BoolePreprocessor
        43 preprocessor = BoolePreprocessor + \
        44 LineSkipper(["BooleInit.Boole...SUCCESS Exceptions/Errors/Warnings/Infos Statistics : 0/0/1/0"])
        49
        50 from Boole.QMTest.BooleExclusions import preprocessor
        45 51 validateWithReference(preproc = preprocessor)
        • Marco Cattaneo
          Marco Cattaneo @cattanem ·
          Maintainer

          @rmatev is it really necessary to compare the raw event dump against a reference? When it was only one (VP) bank the output changed only if the VP changed, but now each and every change to Boole requires an update of the reference file of this test, which has huge (and meaningless IMHO diffs). Any objection to removing the validateWithReference and keeping only the check-raw-data validation?

          Edited by Marco Cattaneo
        • Please register or sign in to reply
        Please register or sign in to reply