Skip to content
Snippets Groups Projects

Muon background no m1 fix

Merged Muon background no m1 fix
MuonBackground_noM1_fix into master
All threads resolved!
Merged Alessia Satta requested to merge MuonBackground_noM1_fix into master
All threads resolved!

Few fixes for no M1 simulation. Using the code without this fixes

  1. M2 low energy was not added
  2. in M3 M4 M5 the wrong parametherizations were uses (M3 uses M2, M4 uses M3 and M5 uses M4)
  3. in flat background addition wrong number of hits were added Please not that the code on this branch does not allow the simulation with M1 anymore.

Merge request reports

Merge request pipeline #5063854 passed

Stage: test
Stage: .post

Merge request pipeline passed for 8a81ad37

Merged by Erika De LuciaErika De Lucia 2 years ago (Feb 15, 2023 11:00am UTC)

Loading

Pipeline #5136564 passed

Stage: test

Pipeline passed for 59465b8f on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Gloria Corti requested review from @edelucia

    requested review from @edelucia

  • Gloria Corti marked this merge request as draft

    marked this merge request as draft

  • Gloria Corti
    Gloria Corti @gcorti ·
    Maintainer

    Added the Draft: to be solved once ready to be tested in all-slots for final checks before merging

    Edited by Gloria Corti
  • Software for LHCb added ci-test-triggered label

    added ci-test-triggered label

  • L
    Software for LHCb @lhcbsoft ·
    Developer
    Edited by Software for LHCb
  • Erika De Lucia
    Erika De Lucia @edelucia ·
    Maintainer

    @satta are there any updates?

  • Erika De Lucia removed ci-test-triggered label

    removed ci-test-triggered label

  • Erika De Lucia marked this merge request as ready

    marked this merge request as ready

  • Erika De Lucia resolved all threads

    resolved all threads

  • Erika De Lucia mentioned in commit 59465b8f

    mentioned in commit 59465b8f

  • Erika De Lucia merged

    merged

  • Software for LHCb mentioned in commit 843b04f0

    mentioned in commit 843b04f0

    • L
      Software for LHCb @lhcbsoft ·
      Developer
      Resolved by Erika De Lucia

      The RefBot pipeline created the following reference update MRs: !452 (merged)

      Click this to see encountered Boole warnings 
      Boole/x86_64_v2-centos7-gcc11-opt: Test Boole.boole-write-xdigi contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-gcc11-opt: Test Boole.boole-upgrade-baseline contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-gcc11-opt: Test Boole.boole-dump-raw contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-gcc11-opt: Test Boole.boole-FT contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-gcc11-opt: Test Boole.boole-Rich contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-gcc11-opt: Test Boole.boole-UT contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-gcc11-opt: Test Boole.boole-VP contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-gcc11-opt: Test Boole.boole-reprocess-xdigi contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-gcc11-opt: Test Boole.check-raw-data contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-gcc11-opt: Test Boole.boole-spillover contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-gcc11-opt: Test without ref failed: Boole.check-raw-data!
Boole/x86_64_v2-centos7-gcc11-dbg: Test Boole.boole-upgrade-baseline contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-gcc11-dbg: Test Boole.boole-write-xdigi contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-gcc11-dbg: Test Boole.boole-dump-raw contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-gcc11-dbg: Test Boole.boole-FT contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-gcc11-dbg: Test Boole.boole-Rich contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-gcc11-dbg: Test Boole.boole-UT contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-gcc11-dbg: Test Boole.boole-VP contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-gcc11-dbg: Test Boole.boole-reprocess-xdigi contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-gcc11-dbg: Test Boole.check-raw-data contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-gcc11-dbg: Test Boole.boole-spillover contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-gcc11-dbg: Test without ref failed: Boole.check-raw-data!
Boole/x86_64_v2-centos7-clang12-opt: Test Boole.boole-write-xdigi contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-clang12-opt: Test Boole.boole-upgrade-baseline contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-clang12-opt: Test Boole.boole-dump-raw contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-clang12-opt: Test Boole.boole-FT contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-clang12-opt: Test Boole.boole-Rich contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-clang12-opt: Test Boole.boole-UT contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-clang12-opt: Test Boole.boole-VP contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-clang12-opt: Test Boole.boole-reprocess-xdigi contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-clang12-opt: Test Boole.boole-spillover contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-clang12-opt: Test Boole.check-raw-data contains nonzero exit code and/or warnings!
Boole/x86_64_v2-centos7-clang12-opt: Test without ref failed: Boole.check-raw-data!
Boole/x86_64_v3-centos7-gcc11-opt+g: Test Boole.boole-upgrade-baseline contains nonzero exit code and/or warnings!
Boole/x86_64_v3-centos7-gcc11-opt+g: Test Boole.boole-write-xdigi contains nonzero exit code and/or warnings!
Boole/x86_64_v3-centos7-gcc11-opt+g: Test Boole.boole-dump-raw contains nonzero exit code and/or warnings!
Boole/x86_64_v3-centos7-gcc11-opt+g: Test Boole.boole-FT contains nonzero exit code and/or warnings!
Boole/x86_64_v3-centos7-gcc11-opt+g: Test Boole.boole-Rich contains nonzero exit code and/or warnings!
Boole/x86_64_v3-centos7-gcc11-opt+g: Test Boole.boole-UT contains nonzero exit code and/or warnings!
Boole/x86_64_v3-centos7-gcc11-opt+g: Test Boole.boole-VP contains nonzero exit code and/or warnings!
Boole/x86_64_v3-centos7-gcc11-opt+g: Test Boole.boole-reprocess-xdigi contains nonzero exit code and/or warnings!
Boole/x86_64_v3-centos7-gcc11-opt+g: Test Boole.check-raw-data contains nonzero exit code and/or warnings!
Boole/x86_64_v3-centos7-gcc11-opt+g: Test Boole.boole-spillover contains nonzero exit code and/or warnings!
Boole/x86_64_v3-centos7-gcc11-opt+g: Test without ref failed: Boole.check-raw-data!
Boole: Update of Digi/Boole/tests/refs/boole-write-xdigi.ref not possible. No successful test platforms:
[('x86_64_v2-centos7-gcc11-opt', 'error'),
 ('x86_64_v2-centos7-gcc11-dbg', 'error'),
 ('x86_64_v2-centos7-clang12-opt', 'error'),
 ('x86_64_v3-centos7-gcc11-opt+g', 'error')]
Boole: Update of Digi/Boole/tests/refs/boole-upgrade-baseline.ref not possible. No successful test platforms:
[('x86_64_v2-centos7-gcc11-opt', 'error'),
 ('x86_64_v2-centos7-gcc11-dbg', 'error'),
 ('x86_64_v2-centos7-clang12-opt', 'error'),
 ('x86_64_v3-centos7-gcc11-opt+g', 'error')]
Boole: Update of Digi/Boole/tests/refs/boole-dump-raw.ref not possible. No successful test platforms:
[('x86_64_v2-centos7-gcc11-opt', 'error'),
 ('x86_64_v2-centos7-gcc11-dbg', 'error'),
 ('x86_64_v2-centos7-clang12-opt', 'error'),
 ('x86_64_v3-centos7-gcc11-opt+g', 'error')]
Boole: Correctness for treatment of Boole.boole-FT not guaranteed. Test platforms with unclear statuses:
[('x86_64_v2-centos7-gcc11-opt', 'error'),
 ('x86_64_v2-centos7-gcc11-dbg', 'error'),
 ('x86_64_v2-centos7-clang12-opt', 'error'),
 ('x86_64_v3-centos7-gcc11-opt+g', 'error')]
Boole: Correctness for treatment of Boole.boole-Rich not guaranteed. Test platforms with unclear statuses:
[('x86_64_v2-centos7-gcc11-opt', 'error'),
 ('x86_64_v2-centos7-gcc11-dbg', 'error'),
 ('x86_64_v2-centos7-clang12-opt', 'error'),
 ('x86_64_v3-centos7-gcc11-opt+g', 'error')]
Boole: Correctness for treatment of Boole.boole-UT not guaranteed. Test platforms with unclear statuses:
[('x86_64_v2-centos7-gcc11-opt', 'error'),
 ('x86_64_v2-centos7-gcc11-dbg', 'error'),
 ('x86_64_v2-centos7-clang12-opt', 'error'),
 ('x86_64_v3-centos7-gcc11-opt+g', 'error')]
Boole: Correctness for treatment of Boole.boole-VP not guaranteed. Test platforms with unclear statuses:
[('x86_64_v2-centos7-gcc11-opt', 'error'),
 ('x86_64_v2-centos7-gcc11-dbg', 'error'),
 ('x86_64_v2-centos7-clang12-opt', 'error'),
 ('x86_64_v3-centos7-gcc11-opt+g', 'error')]
Boole: Update of Digi/Boole/tests/refs/boole-reprocess-xdigi.ref not possible. No successful test platforms:
[('x86_64_v2-centos7-gcc11-opt', 'error'),
 ('x86_64_v2-centos7-gcc11-dbg', 'error'),
 ('x86_64_v2-centos7-clang12-opt', 'error'),
 ('x86_64_v3-centos7-gcc11-opt+g', 'error')]
Boole: Update of Digi/Boole/tests/refs/boole-spillover.ref not possible. No successful test platforms:
[('x86_64_v2-centos7-gcc11-opt', 'error'),
 ('x86_64_v2-centos7-gcc11-dbg', 'error'),
 ('x86_64_v2-centos7-clang12-opt', 'error'),
 ('x86_64_v3-centos7-gcc11-opt+g', 'error')]
Boole: Found diff for symlinked ref: Digi/Boole/tests/refs/boole-UT.ref, but original ref: Digi/Boole/tests/refs/boole-UT.ref.detdesc is unchanged
Boole: Found diff for symlinked ref: Digi/Boole/tests/refs/boole-VP.ref, but original ref: Digi/Boole/tests/refs/boole-VP.ref.detdesc is unchanged
Boole: Found diff for symlinked ref: Digi/Boole/tests/refs/boole-FT.ref, but original ref: Digi/Boole/tests/refs/boole-FT.ref.detdesc is unchanged
Boole: Found diff for symlinked ref: Digi/Boole/tests/refs/boole-Rich.ref, but original ref: Digi/Boole/tests/refs/boole-Rich.ref.detdesc is unchanged

  • Software for LHCb mentioned in merge request !452 (merged)

    mentioned in merge request !452 (merged)

  • Rosen Matev added Muon bug fix labels

    added Muon bug fix labels

  • Rosen Matev mentioned in commit d2987390

    mentioned in commit d2987390

  • Erika De Lucia resolved all threads

    resolved all threads

Please register or sign in to reply