Merge branch 'erodrigu-DaVinciSys-pytests-1' into 'master'

Add Pytest tests for the davinci script in DaVinciSys

See merge request !608

DaVinciSys/CMakeLists.txt

@@ -16,3 +16,4 @@ DaVinciSys
 gaudi_install(SCRIPTS)
 
 gaudi_add_tests(QMTest)
+gaudi_add_tests(pytest ${CMAKE_CURRENT_SOURCE_DIR}/tests)

DaVinciSys/tests/__init__.py

+##############################################################################
+# (c) Copyright 2021 CERN for the benefit of the LHCb Collaboration           #
+#                                                                             #
+# This software is distributed under the terms of the GNU General Public      #
+# Licence version 3 (GPL Version 3), copied verbatim in the file "COPYING".   #
+#                                                                             #
+# In applying this licence, CERN does not waive the privileges and immunities #
+# granted to it by virtue of its status as an Intergovernmental Organization  #
+# or submit itself to any jurisdiction.                                       #
+###############################################################################

DaVinciSys/tests/test_davinci_script.py

+##############################################################################
+# (c) Copyright 2021 CERN for the benefit of the LHCb Collaboration           #
+#                                                                             #
+# This software is distributed under the terms of the GNU General Public      #
+# Licence version 3 (GPL Version 3), copied verbatim in the file "COPYING".   #
+#                                                                             #
+# In applying this licence, CERN does not waive the privileges and immunities #
+# granted to it by virtue of its status as an Intergovernmental Organization  #
+# or submit itself to any jurisdiction.                                       #
+###############################################################################
+
+import subprocess, os
+import pytest
+
+
+def test_default():
+    """
+    Check that the simple `davinci` command works.
+    """
+    result = subprocess.run("davinci", shell=True)
+    assert result.returncode == 0
+
+
+def test_invalid_option():
+    """
+    Check that an unknown `davinci` option results in an exit code error.
+    """
+    with pytest.raises(subprocess.CalledProcessError):
+        _ = subprocess.run("davinci --unknown", shell=True, check=True)
+
+
+def test_override_job_option():
+    """
+    Verify the overriding of a DaVinci option on the fly.
+    No need to actually run the job, hence the dry run.
+    """
+    cmd = 'davinci --export test_override_job_option.opts --dry-run run-mc --overwrite_data_options True --unpack_stream "/Event/Unknown" --inputfiledb Upgrade_Bd2KstarMuMu -'
+    result = subprocess.run(cmd, shell=True)
+
+    # Just be maniac - the command should work ;-)
+    assert result.returncode == 0
+
+    # Inspect the produced .opts file and check for the option value overridden
+    with open("test_override_job_option.opts") as f:
+        assert any('.unpack_stream = "/Event/Unknown";' in line
+                   for line in f.readlines())
+
+    os.remove("test_override_job_option.opts")