Follow-up from "Resolve Tupling test running on spruced output" and " Remove old davinci configurable and related tests"

Follow up from !573 (merged) to be addressed:

• @sstahl started a discussion about
  • removing the unpacking function from the HltControlFlow
  • adding an Event prefilter (or something similar and more compatible with PyConf) in order to reduce the amount of time required by unpacking all the hlt locations
• @erodrigu started a discussion about
  • possibility to move the set_hltAnn_svc from DaVinci.algorithms to GaudiConf

Follow up from !568 (merged) to be addressed:

• @pkoppenb started a discussion about
  • maintaining the possibility to write .dst in DaVinci.

assigned to @dfazzini

added DPA-WP3 Tuples labels

mentioned in merge request !577 (merged)

added Configuration label

The " Remove old davinci configurable and related tests" part should be " Remove old davinci configurable and translate related tests ". Most of these tests are covering important features.

For instance in !549 (merged) I just edited a gaudirun.py test. I should translate it, I guess.

But we should also keep the functionality and test it, see https://gitlab.cern.ch/lhcb-dpa/project/-/issues/132#note_4782149

marked the checklist item @sstahl started a discussion about as completed

marked the checklist item @sstahl started a discussion about as incomplete

marked the checklist item @sstahl started a discussion about as completed

Hey @dfazzini, I bumped into this relatively old task. Can you update us on the status here (sorry, can't remember it all) and let us know whether you can pick this up next? Thanks.

Hi @erodrigu, in fact there were not updates on this side so far since I was working on the other DaVinci tasks. Moving the 'set_hltAnn_svc' in pyConf should be quite an easy task but I think it is better to wait until !618 (merged) is merged. Regarding the replacement of the DstWriter algorithm, I had a look a few time ago and it turned out to be a bit more complex than what expected. I will try to look at it again in the next few days.

Good morning. Sounds great and fair. Thanks @dfazzini.

Hi @erodrigu, @rmatev, I am preparing the MR to move these two functions from DaVinci to LHCb package so they could be used also by other projects:

• DaVinci.algorithms.set_hltAnn_svc, https://gitlab.cern.ch/lhcb/DaVinci/-/blob/master/Phys/DaVinci/python/DaVinci/algorithms.py#L348
• DaVinci.algorithms.get_hltAnn_dict, https://gitlab.cern.ch/lhcb/DaVinci/-/blob/master/Phys/DaVinci/python/DaVinci/algorithms.py#L319.

The original idea was to move them to LHCb.PyConf package (I think in the applications.py script) but I thought also of another possible location, i.e. LHCb.GaudiConf in the reading.py script along with the other Hlt related functions implemented with LHCb!3303 (merged).

What do you think is the best solution?

I think LHCb.GaudiConf is probably a better place, yes.

Done via LHCb!3377 (merged), @dfazzini, or you want to do something else on this "front"?

No, for the moment I don't have anything else to add. The only thing still missing is the new tool for writing .dst file, I don't have too much time to work on this in the short time but I have it in my to-do list.

I see. By then I hope we will avoid duplication and will work towards Moore#372 (closed). That seems the right way IMO.

Good point. I will implement it in the LHCb package so it can be use by all the other applications.

BTW, you probably know already but various writers are at https://gitlab.cern.ch/lhcb/LHCb/-/blob/master/PyConf/python/PyConf/application.py.

yes, I saw them but up tp now I didn't have the chance to look deep inside them to see how they works. I will surely do asap, thanks for the suggestion!

@dfazzini, can you update us here on the third item of the to-dos above? I believe that writing is possible. The task you have in mind is the implementation of a test to ensure that, or, probably best, an example of how to do it? I may be missing something on this task? Thanks.

Hi @erodrigu, yes the idea is to prepare an example for showing how to write a .dst with DaVinci. I am a bit busy with other commitments in these days but I will try to complete this issue asap.

No probs. Thanks for the confirmation.

As this task has been open for a while and looks as blocking more general planning I moved the little item unticked so far to a separate issue #64 (moved). The grand topic of this task is indeed dealt with since a while.

mentioned in merge request LHCb!3377 (merged)

mentioned in merge request !630 (merged)

changed the description

marked the checklist item @erodrigu started a discussion about as completed

changed the description

mentioned in merge request !715

mentioned in issue #64 (moved)

closed