DaVinci merge requestshttps://gitlab.cern.ch:8443/lhcb/DaVinci/-/merge_requests2024-03-28T14:13:53+01:00https://gitlab.cern.ch:8443/lhcb/DaVinci/-/merge_requests/1058Test genfsr - add required missing option2024-03-28T14:13:53+01:00Eduardo RodriguesTest genfsr - add required missing optionFYI @amathad. Indeed the test DaVinciTests/tests/qmtest/fsrs.qms/test-genfsr.qmt had been failing for a while. At this point I'm not going to try and dig where the "ref update" change comes from. This is the required ref update to the ge...FYI @amathad. Indeed the test DaVinciTests/tests/qmtest/fsrs.qms/test-genfsr.qmt had been failing for a while. At this point I'm not going to try and dig where the "ref update" change comes from. This is the required ref update to the generator FSR XML.
Update: original issue is more convoluted. Making this trivial update for now, as a first step. We need to look at the merging of FSRs, as something fishy is going on, see discussions below.Eduardo RodriguesEduardo Rodrigueshttps://gitlab.cern.ch:8443/lhcb/DaVinci/-/merge_requests/1061Follow https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4496 (Remove data_ty...2024-03-26T10:00:02+01:00Abhijit MathadFollow https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4496 (Remove data_type option)
Test with: https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4496, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3209, https://gitlab.cern.ch/lhcb-datapkg/AppConfig/-/merge_requests/233
Closes https://gitlab.cern.ch/lhcb/DaVinci/-...
Test with: https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4496, https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3209, https://gitlab.cern.ch/lhcb-datapkg/AppConfig/-/merge_requests/233
Closes https://gitlab.cern.ch/lhcb/DaVinci/-/issues/176Abhijit MathadAbhijit Mathadhttps://gitlab.cern.ch:8443/lhcb/DaVinci/-/merge_requests/1050adapt to newly persisted calo pid objects2024-03-25T11:47:43+01:00Maarten Van Vegheladapt to newly persisted calo pid objectsfor https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4338 https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3740 https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3149
also adding testing to https://gitlab.cern.ch/lhcb/LHCbIntegrationT...for https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4338 https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3740 https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3149
also adding testing to https://gitlab.cern.ch/lhcb/LHCbIntegrationTests/-/merge_requests/63RTA/2024.03.27Anfeng LiAnfeng Lihttps://gitlab.cern.ch:8443/lhcb/DaVinci/-/merge_requests/1013Follow up on particle PV pointer, offline PV unbiasing example2024-03-22T16:00:46+01:00Wouter Hulsbergenwouterh@nikhef.nlFollow up on particle PV pointer, offline PV unbiasing exampleTo go with LHCb!4299, Rec!3665, Moore!2658
Example of PV unbiasing, using PV constraints in DTF.
Closing Moore#608To go with LHCb!4299, Rec!3665, Moore!2658
Example of PV unbiasing, using PV constraints in DTF.
Closing Moore#608https://gitlab.cern.ch:8443/lhcb/DaVinci/-/merge_requests/1060Update References for: LHCb!4457, Rec!3783, Boole!549 based on lhcb-master-mr...2024-03-22T11:51:01+01:00Software for LHCbUpdate References for: LHCb!4457, Rec!3783, Boole!549 based on lhcb-master-mr/11193https://gitlab.cern.ch:8443/lhcb/DaVinci/-/merge_requests/1019Update HltEfficiencyChecker examples to use 2024 min bias samples2024-03-21T16:55:54+01:00Ross John HunterUpdate HltEfficiencyChecker examples to use 2024 min bias samplesGoes with https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3164
This MR overhauls the HltEfficiencyChecker examples (and hence tests). For rate testing, expected-2024 samples are now used, and a 2024-like reconstruction scenario is al...Goes with https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3164
This MR overhauls the HltEfficiencyChecker examples (and hence tests). For rate testing, expected-2024 samples are now used, and a 2024-like reconstruction scenario is also used. In the `yaml` wizard files, the two reconstruction options for hlt2 are now `current_without_UT` and `future_with_UT`. For HLT1, the default sequence we use should now be `hlt1_pp_forward_then_matching_no_ut` rather than `hlt1_pp_default`.
The `hlt2_rate_example{.py,.yaml}` now reflects the 2024-like scenario, both in terms of input sample and reconstruction configuration. `hlt2_rate_hlt1latestBWdiv.py` is therefore removed.
Also removed some now-redundant `no_gec` HLT1 sequence tests, as there is no GEC by default now in Allen.
All tests green for me locally.
Also close #180 while I'm here - it was an easy fix.
TODO:
* [x] Mirror these changes in the documentation - https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/3164
* [x] Remove RetinaCluster-related binds
* [x] ~~Update to newer samples for measuring efficiency? Next time~~
* [x] Update thoroughly to use new reconstruction sequences for measuring efficiency?
* [x] Ensure consistency between the .yaml and .py optionsRoss John HunterAnfeng LiRoss John Hunterhttps://gitlab.cern.ch:8443/lhcb/DaVinci/-/merge_requests/1034Review lumi job options2024-03-21T12:58:58+01:00Edoardo FranzosoReview lumi job optionsReview of the luminosity options for standard DV jobs.
Closes [https://gitlab.cern.ch/lhcb/DaVinci/-/issues/142](https://gitlab.cern.ch/lhcb/DaVinci/-/issues/142).Review of the luminosity options for standard DV jobs.
Closes [https://gitlab.cern.ch/lhcb/DaVinci/-/issues/142](https://gitlab.cern.ch/lhcb/DaVinci/-/issues/142).Eduardo RodriguesEdoardo FranzosoEduardo Rodrigueshttps://gitlab.cern.ch:8443/lhcb/DaVinci/-/merge_requests/1055Update References for: LHCb!4299, Rec!3665, Moore!2658, Alignment!445, DaVinc...2024-03-18T15:08:08+01:00Software for LHCbUpdate References for: LHCb!4299, Rec!3665, Moore!2658, Alignment!445, DaVinci!1013 based on lhcb-master-mr/11111https://gitlab.cern.ch:8443/lhcb/DaVinci/-/merge_requests/1039Add Functor Collection with Charged Calo Information2024-03-08T16:23:51+01:00Albert Lopez HuertasAdd Functor Collection with Charged Calo InformationThis Functor Collection contains all the variables related to Charged Calo Information, including also PID variables from Calo, used in electron analyses.
FYI: @cmarinbe @lcalefic @pvidrier @palaguarThis Functor Collection contains all the variables related to Charged Calo Information, including also PID variables from Calo, used in electron analyses.
FYI: @cmarinbe @lcalefic @pvidrier @palaguarAlbert Lopez HuertasAlbert Lopez Huertashttps://gitlab.cern.ch:8443/lhcb/DaVinci/-/merge_requests/1043use `os.remove(f)` instead of `os.system(f"rm {f}")`2024-03-06T15:47:40+01:00Gerhard Ravenuse `os.remove(f)` instead of `os.system(f"rm {f}")`https://gitlab.cern.ch:8443/lhcb/DaVinci/-/merge_requests/1045Follow-up from https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/44042024-03-05T19:20:08+01:00Eduardo RodriguesFollow-up from https://gitlab.cern.ch/lhcb/LHCb/-/merge_requests/4404FYI @graven and @eleckste.
While at it I believe I got rid of some trivial failures sitting there in other platforms since a while.FYI @graven and @eleckste.
While at it I believe I got rid of some trivial failures sitting there in other platforms since a while.Eduardo RodriguesEduardo Rodrigueshttps://gitlab.cern.ch:8443/lhcb/DaVinci/-/merge_requests/1046Release v64r22024-03-05T19:14:09+01:00Davide FazziniRelease v64r2Davide FazziniDavide Fazzinihttps://gitlab.cern.ch:8443/lhcb/DaVinci/-/merge_requests/1037Adapt FT example to new FT functors2024-03-05T17:38:59+01:00Claire ProuveAdapt FT example to new FT functorsadjust the functor names in the options file to use the new functors for the tagging decision and mistag
goes with https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3453adjust the functor names in the options file to use the new functors for the tagging decision and mistag
goes with https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3453Eduardo RodriguesAbhijit MathadEduardo Rodrigueshttps://gitlab.cern.ch:8443/lhcb/DaVinci/-/merge_requests/1044Update References for: Moore!2747 based on lhcb-master-mr/107852024-02-28T22:22:33+01:00Software for LHCbUpdate References for: Moore!2747 based on lhcb-master-mr/10785https://gitlab.cern.ch:8443/lhcb/DaVinci/-/merge_requests/1035Add example for use of own and unbiased PV with DTF2024-02-27T16:07:37+01:00Wouter Hulsbergenwouterh@nikhef.nlAdd example for use of own and unbiased PV with DTFThis adds an example for using unbiased PVs.
It cannot currently be merged because the file use for the test does not persists PVs with tracks, not Particles with PV pointers.
To make the example for unbiasing, we need the v1 PVs with ...This adds an example for using unbiased PVs.
It cannot currently be merged because the file use for the test does not persists PVs with tracks, not Particles with PV pointers.
To make the example for unbiasing, we need the v1 PVs with velo tracks.
To make the example using 'ownpv' (e.g. particle->pv()), we need particles persisted with PV pointers.
@sesen
@sperazziWouter Hulsbergenwouterh@nikhef.nlWouter Hulsbergenwouterh@nikhef.nlhttps://gitlab.cern.ch:8443/lhcb/DaVinci/-/merge_requests/968Fix the creation of the luminosity TTree2024-02-23T20:54:09+01:00Eduardo RodriguesFix the creation of the luminosity TTreeAs per recent exchanges on Mattermost and the fact that at the moment the TTree was only written if a manifest_file was provided in the configuration.
I now switched the writing of the TTree by default to True.As per recent exchanges on Mattermost and the fact that at the moment the TTree was only written if a manifest_file was provided in the configuration.
I now switched the writing of the TTree by default to True.Eduardo RodriguesEduardo Rodrigueshttps://gitlab.cern.ch:8443/lhcb/DaVinci/-/merge_requests/1028Adjust to new flavour tagging algorithm names2024-02-19T12:30:15+01:00Claire ProuveAdjust to new flavour tagging algorithm namesgoes with https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3749 and https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2949goes with https://gitlab.cern.ch/lhcb/Rec/-/merge_requests/3749 and https://gitlab.cern.ch/lhcb/Moore/-/merge_requests/2949https://gitlab.cern.ch:8443/lhcb/DaVinci/-/merge_requests/1036Release v64r12024-02-13T18:06:02+01:00Davide FazziniRelease v64r1Davide FazziniDavide Fazzinihttps://gitlab.cern.ch:8443/lhcb/DaVinci/-/merge_requests/1022Move FunTuple to DaVinci2024-02-13T16:57:48+01:00Abhijit MathadMove FunTuple to DaVinciMoving FunTuple to DV.
Test with: https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1049Moving FunTuple to DV.
Test with: https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/1049Abhijit MathadAbhijit Mathadhttps://gitlab.cern.ch:8443/lhcb/DaVinci/-/merge_requests/1033Fix .gitlab-ci.yml for the build to work with LCG 1052024-02-13T16:57:28+01:00Eduardo RodriguesFix .gitlab-ci.yml for the build to work with LCG 105Indeed better to fix the failing build asap and this bit part of https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1029 would take longer to merge. This can go in asap to fix the builds.Indeed better to fix the failing build asap and this bit part of https://gitlab.cern.ch/lhcb/DaVinci/-/merge_requests/1029 would take longer to merge. This can go in asap to fix the builds.Eduardo RodriguesEduardo Rodrigues