Move HltEfficiencyChecker from MooreAnalysis to DaVinci

Goes with Moore!2812 (merged) (docs changes).

Move the remaining contents of MooreAnalysis (only the HltEfficiencyChecker package) into DaVinci, merging in the git history as well (following instructions here).

Also made a handful of commits here on top to please the pre-commit hooks, update a README, and get it to build & test. All working for me locally.

TODO:

• Make sure moved tests work

assigned to @rjhunter

changed the description

added MC checking RTA labels

added 2 commits

• fb239257 - remove unused import
• 6a0d7132 - Use raw strings to please linter

Compare with previous version

added 1 commit

• 24ef6a99 - pre-commit fixes

Compare with previous version

added 1 commit

• 15938824 - Please spell checker

Compare with previous version

FYI @amathad @erodrigu still very WIP here (I have to make docs changes in Moore, also try to get some things merged in MooreAnalysis/move the open MRs here, same for issues... maybe more to do...) but just in case you're interested, its going to look roughly like this.

mentioned in issue #157 (closed)

mentioned in issue #164

mentioned in issue #163

mentioned in issue #162 (closed)

mentioned in issue #161

mentioned in issue #160

mentioned in issue #159 (closed)

mentioned in issue #158

mentioned in issue MooreAnalysis#45 (closed)

added 37 commits

• 15938824...17b01fa2 - 8 commits from branch master
• 17b01fa2...87ed1e7e - 19 earlier commits
• 4f763c93 - Replace second while loop in intersects with iteration of existing object
• 9af48fa9 - Documentation and formatting changes
• ed48eb68 - Fixed formatting
• 9f11b007 - Apply efficiency group calculation bug fix from @rjhunter
• 13505bb6 - Merge branch 'follow-moore!2166' into 'master'
• 3383e641 - Explicitly specify old CALO raw banks or old muon decoding in HltEfficiencyChecker yaml options
• e8da7cc5 - Merge branch 'rjhunter-hltefficiencychecker-new-yaml-options' into 'master'
• 53825080 - Trim and move README into HltEfficiencyChecker
• 65ae2554 - Move HltEfficiencyChecker pruned into new dir before move to DaVinci
• 9357e3b7 - Merge branch 'hltefficiencychecker-to-davinci' of...

Compare with previous version

added 2 commits

• 333a8f00 - Please pre-commit hooks
• e2849474 - Add HltEfficiencyChecker to list of subdirectories

Compare with previous version

changed the description

mentioned in merge request Moore!2812 (merged)

marked the checklist item Make sure moved tests work as completed

changed title from Draft: First attempt to move HltEfficiencyChecker from MooreAnalysis to DaVinci to Draft: Move HltEfficiencyChecker from MooreAnalysis to DaVinci

mentioned in merge request MooreAnalysis!135 (merged)

marked this merge request as ready

requested review from @erodrigu and @amathad

• [2023-12-18 17:44] Validation started with lhcb-master-mr#9965
• [2023-12-19 01:07] Validation started with lhcb-master-mr#9967
• [2023-12-19 10:41] Validation started with lhcb-master-mr#9970

approved this merge request

resolved all threads

added 1 commit

• 10254b9f - Remove remaining references to MooreAnalysis; swap for DaVinci

Compare with previous version

Ahh crap, forgot to push that last commit before starting the CI test. It might be OK anyway. Oh well, I'll have to start another one tomorrow.

I am trying to look up, how to kill the build.

I asked the shifter directly - I think it is only they who can do it. They haven't responded yet. If you have the authority then a button appears on the nightlies page to abort a test.

I don't have the karma, but need to request it. Lets see if the shifter responds.

No response yet. I'm going home now, please feel free to start another test e.g. early tomorrow - you'll probably get to your desk in Zurich before I do in the UK ;)

The latest test was successful. We see 17 new passing tests for DaVinci, and the MooreAnalysis tests and build have been removed in the MooreAnalysis MR.

I think certainly this MR and the Moore docs MR can be merged now. The MooreAnalysis one should probably be looked over by the maintainer in case there's anything else I need to do in retiring MooreAnalysis.

Any further review @amathad or do we merge it?

Great! Thanks a lot Ross

Thanks for merging!

Do you also have karma to merge the changes to the docs in Moore!2812 (merged)?

I see that you have. Many thanks!

Technically the documentation of the HltEfficiencyChecker needs to be moved to DV? But I think its okay there as people are used to it.

changed the description

resolved all threads

approved this merge request

merged

mentioned in commit 8e580513

resolved all threads

resolved all threads

added enhancement label