Following changes in Moore!2907

Following partial migration and renaming of RecoConf.hlt1_tracking -> RecoConf.legacy_rec_hlt1_tracking and RecoConf.hlt1_muonid -> RecoConf.muonid

Part of the set: Moore!2907 (merged) lhcb-datapkg/PRConfig!386 (merged) MooreOnline!326 (merged) Alignment!458 (merged) Panoptes!317 (merged) !1038 (merged)

FYI: @rjhunter

added RTA cleanup testing labels

requested review from @rjhunter

assigned to @msaur

changed the description

mentioned in merge request Moore!2907 (merged)

Hi @msaur, changes look fine to me but could you perhaps also change the documentation under Moore/doc/tutorials/hltefficiencychecker.rst in the same way please?

I have a medium-term goal to use literalinclude there so that these kind of changes don't have to be duplicated, but I didn't get around to it yet.

approved this merge request

MyPy can be tricky/fussy at times. I've had troubles regularly with non-trivial changes requested when moving to newer versions of MyPy.

In this instance it could be that you will need # type: ignore[attr-defined] or even # type: ignore[attr-defined,import]? This is surprising, though.

But the CI is green above, so you're good and can ignore? I don't have time to investigate, especially that I do not see how you are getting a different error than the CI.

added 1 commit

• 28a279f2 - copyright update

Compare with previous version

mentioned in merge request Alignment!458 (merged)

• [2024-02-17 07:39] Validation started with lhcb-master-mr#10623
• [2024-02-20 07:02] Validation started with lhcb-master-mr#10650
• [2024-03-06 06:34] Validation started with lhcb-master-mr#10904
• [2024-03-13 05:01] Validation started with lhcb-master-mr#11018
• [2024-03-13 14:53] Validation started with lhcb-master-mr#11027
• [2024-03-14 10:04] Validation started with lhcb-master-mr#11042
• [2024-03-14 11:08] Validation started with lhcb-master-mr#11045
• [2024-03-15 04:06] Validation started with lhcb-master-mr#11065
• [2024-03-16 06:33] Validation started with lhcb-master-mr#11087
• [2024-03-16 08:35] Validation started with lhcb-master-mr#11088
• [2024-03-17 06:37] Validation started with lhcb-master-mr#11101
• [2024-03-17 10:10] Validation started with lhcb-master-mr#11105
• [2024-03-18 05:18] Validation started with lhcb-master-mr#11115
• [2024-03-19 06:29] Validation started with lhcb-master-mr#11133
• [2024-03-20 03:39] Validation started with lhcb-master-mr#11155
• [2024-03-20 11:36] Validation started with lhcb-master-mr#11158
• [2024-03-26 14:43] Validation started with lhcb-master-mr#11245
• [2024-03-27 15:56] Validation started with lhcb-master-mr#11266
• [2024-03-28 04:33] Validation started with lhcb-master-mr#11270
• [2024-03-28 18:43] Validation started with lhcb-master-mr#11286
• [2024-03-29 10:44] Validation started with lhcb-master-mr#11298
• [2024-03-30 09:05] Validation started with lhcb-master-mr#11306
• [2024-03-30 18:05] Validation started with lhcb-master-mr#11309
• [2024-03-31 08:37] Validation started with lhcb-master-mr#11310
• [2024-04-01 12:06] Validation started with lhcb-master-mr#11314

added 1 commit

• 4c931bc5 - fixing missed hlt1_tracking import, prefering...

Compare with previous version

added 1 commit

• 9d3960f3 - enforcing set_input_and_conds_from_testfiledb over separate set_input and...

Compare with previous version

added 1 commit

• 8ffd5b00 - fixing missed hlt1_tracking imports

Compare with previous version

added 7 commits

• 8ffd5b00...6f066f15 - 4 commits from branch master
• 78a9c1d8 - following changes in Moore2907
• f3c5ce44 - copyright update
• 7ee7be07 - fixing missed hlt1_tracking imports

Compare with previous version

added 5 commits

• 7ee7be07...c69e8bbb - 2 commits from branch master
• 985666c5 - following changes in Moore2907
• 1f4d895b - copyright update
• d6c69913 - fixing missed hlt1_tracking imports

Compare with previous version

added 9 commits

• d6c69913...bd69bd13 - 6 commits from branch master
• 133efac5 - following changes in Moore2907
• 4e3e057b - copyright update
• 92acb9ca - fixing missed hlt1_tracking imports

Compare with previous version

mentioned in merge request LHCb!4470 (merged)

mentioned in merge request Moore!3006 (merged)