New functors for estimation of helicity angle

Goes with Rec!3770 (merged)

mentioned in merge request Rec!3770 (merged)

added 1 commit

• 7020e1f6 - Added validation of Helicity angle functor

Compare with previous version

marked this merge request as draft

added 14 commits

• 7020e1f6...bd69bd13 - 12 commits from branch master
• c7e3aec0 - Added validation of Helicity angle functor
• e83565d2 - Updated example for helicity functor

Compare with previous version

added 2 commits

• f47fcff2 - pre-commit fixes
• 0f1843e3 - Removed unused import

Compare with previous version

added 1 commit

• a802c1eb - Fixed DaVinci examples and updated refs

Compare with previous version

added 1 commit

• 4507fd91 - pre-commit fixes

Compare with previous version

marked this merge request as ready

changed title from Draft: New MC functor for estimation of helicity angle to New functors for estimation of helicity angle

requested review from @amathad and @erodrigu

assigned to @vsvintoz

added DPA-WP3 label

approved this merge request

@vsvintoz : Looks good to me. I am approving. Please assign the shifter to the Rec MR and get it tested. Then we can merge his.

added For 2024 data taking label

• [2024-03-20 19:00] Validation started with lhcb-master-mr#11171
• [2024-03-22 18:46] Validation started with lhcb-master-mr#11210
• [2024-04-05 10:52] Validation started with lhcb-master-mr#11383
• [2024-05-23 17:00] Validation started with lhcb-2024-patches-mr#537

added Functors enhancement labels

Hi @vsvintoz, I left a couple of tiny things. Otherwise this is ready, and really nice an addition . Thank you.

added 1 commit

• 6c47b0e0 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit

• 95634957 - Added few comments regarding the usage of helicity functors

Compare with previous version

resolved all threads

approved this merge request

added 1 commit

• 18426586 - Renamed helicity functors

Compare with previous version

added 2 commits

• efeffb80 - pre-commit fixes
• 60c19154 - Copyright update

Compare with previous version

added 1 commit

• a9d06d68 - Another renaming of helicity functors

Compare with previous version

added 1 commit

• be23ee5d - pre-commit fixes

Compare with previous version

added 19 commits

• be23ee5d...4acc9fc7 - 6 commits from branch master
• 4acc9fc7...1ad7e78c - 3 earlier commits
• 0d4feef0 - Removed unused import
• 6c1aa6d9 - Fixed DaVinci examples and updated refs
• 8a10fc1a - pre-commit fixes
• 319b74c1 - Apply 1 suggestion(s) to 1 file(s)
• 99222ea9 - Added few comments regarding the usage of helicity functors
• f81de697 - Renamed helicity functors
• 5b0548fd - pre-commit fixes
• 6967d3c5 - Copyright update
• 50d48c8a - Another renaming of helicity functors
• 131471a9 - pre-commit fixes

Compare with previous version

mentioned in issue Moore#730 (closed)

added 1 commit

• cc849c22 - Fixed ref files

Compare with previous version

added 1 commit

• 4b750f96 - Ref. update

Compare with previous version

assigned to @masmith

Hello @vsvintoz. This has been a bit dormant. Can you rebase on 2024-patches at this point since analysts will want to use these functions for analysis this year?

Can I ask you @masmith if you have time to make a final pass towards a final CI test and then merging? That would be appreciated.

added 66 commits

• 4b750f96...20223671 - 32 commits from branch master
• 20223671...2790c5ee - 24 earlier commits
• e0af168d - Apply 1 suggestion(s) to 1 file(s)
• 5914020b - Added few comments regarding the usage of helicity functors
• e48594be - Renamed helicity functors
• f5c570ce - pre-commit fixes
• 7a688f6e - Copyright update
• dd1bbb88 - Another renaming of helicity functors
• fd6a15c7 - pre-commit fixes
• 75440007 - Fixed ref files
• 9ef1fd58 - Ref. update
• e01684aa - Updated refs

Compare with previous version

changed target branch from master to 2024-patches

resolved all threads

@masmith @erodrigu This is ready to be merged, I can do it or do you prefer to do it by yourself? Also, what is the DPA policy about squashing commits?

resolved all threads

added 32 commits

• e01684aa...ad5e5625 - 16 commits from branch 2024-patches
• ad5e5625...3a2ba2f7 - 6 earlier commits
• 4f13b77f - Apply 1 suggestion(s) to 1 file(s)
• 1d1cceca - Added few comments regarding the usage of helicity functors
• 949ef0c1 - Renamed helicity functors
• 45c2771f - pre-commit fixes
• e79fb3d0 - Copyright update
• 2e04dfad - Another renaming of helicity functors
• 82f8192a - pre-commit fixes
• 13a1661a - Fixed ref files
• 6ed9ef0c - Ref. update
• 3f4e7ef6 - Updated refs

Compare with previous version

enabled an automatic merge when the pipeline for 3f4e7ef6 succeeds

mentioned in commit 6cd64ed0

merged

mentioned in merge request !1098 (merged)