Validate DaVinci configuration for Turbo data

Ensure that DaVinci() is configured correctly if Turbo = True, throwing an exception if not.

Triggered by discussion in LHCb!954 (merged).

/cc @cattanem

mentioned in merge request LHCb!954 (merged)

• [2017-11-16 14:15] Validation started with lhcb-gaudi-merge#308
• [2017-11-17 00:13] Validation started with lhcb-clang-test#772
• [2017-11-17 00:14] Validation started with lhcb-lcg-dev3#347
• [2017-11-17 00:15] Validation started with lhcb-lcg-dev4#347
• [2017-11-17 00:16] Validation started with lhcb-head#1664
• [2017-11-17 00:16] Validation started with lhcb-gaudi-head#1661
• [2017-11-17 00:17] Validation started with lhcb-2017-patches#206
• [2017-11-17 13:46] Validation started with lhcb-gaudi-merge#309
• [2017-11-17 16:49] Validation started with lhcb-gaudi-merge#310
• [2017-11-17 17:50] Validation started with lhcb-gaudi-merge#311
• [2017-11-17 17:59] Validation started with lhcb-gaudi-merge#312
• [2017-11-17 19:35] Validation started with lhcb-gaudi-merge#313
• [2017-11-17 20:05] Validation started with lhcb-gaudi-merge#314
• [2017-11-18 00:14] Validation started with lhcb-2017-patches#207
• [2017-11-18 00:14] Validation started with lhcb-lcg-dev4#348
• [2017-11-18 00:15] Validation started with lhcb-lcg-dev3#348
• [2017-11-18 00:16] Validation started with lhcb-head#1665
• [2017-11-18 00:16] Validation started with lhcb-gaudi-head#1662
• [2017-11-18 00:17] Validation started with lhcb-clang-test#773
• [2017-11-18 11:23] Validation started with lhcb-gaudi-merge#315
• [2017-11-19 00:12] Validation started with lhcb-lcg-dev4#349
• [2017-11-19 00:13] Validation started with lhcb-2017-patches#208
• [2017-11-19 00:13] Validation started with lhcb-gaudi-head#1663
• [2017-11-19 00:13] Validation started with lhcb-clang-test#774
• [2017-11-19 00:14] Validation started with lhcb-lcg-dev3#349
• [2017-11-19 00:14] Validation started with lhcb-head#1666
• [2017-11-19 11:38] Validation started with lhcb-gaudi-merge#316
• [2017-11-20 00:13] Validation started with lhcb-head#1667
• [2017-11-20 00:13] Validation started with lhcb-lcg-dev3#350
• [2017-11-20 00:14] Validation started with lhcb-lcg-dev4#350
• [2017-11-20 00:15] Validation started with lhcb-clang-test#775
• [2017-11-20 00:15] Validation started with lhcb-2017-patches#209
• [2017-11-20 00:16] Validation started with lhcb-gaudi-head#1664
• [2017-11-20 18:28] Validation started with lhcb-gaudi-merge#317
• [2017-11-20 19:22] Validation started with lhcb-gaudi-head#734
• [2017-11-20 19:45] Validation started with lhcb-gaudi-head#734
• [2017-11-20 20:15] Validation started with lhcb-head#734
• [2017-11-21 00:11] Validation started with lhcb-head#1668
• [2017-11-21 00:12] Validation started with lhcb-lcg-dev4#351
• [2017-11-21 00:13] Validation started with lhcb-gaudi-head#1665
• [2017-11-21 00:14] Validation started with lhcb-clang-test#776
• [2017-11-21 00:15] Validation started with lhcb-2017-patches#210
• [2017-11-21 10:01] Validation started with lhcb-gaudi-head#734
• [2017-11-21 10:30] Validation started with lhcb-gaudi-head#734
• [2017-11-21 12:04] Validation started with lhcb-gaudi-merge#318
• [2017-11-21 12:15] Validation started with lhcb-gaudi-merge#319
• [2017-11-22 00:12] Validation started with lhcb-2017-patches#211
• [2017-11-22 00:12] Validation started with lhcb-lcg-dev3#352
• [2017-11-22 00:12] Validation started with lhcb-clang-test#777
• [2017-11-22 00:12] Validation started with lhcb-head#1669
• [2017-11-22 00:13] Validation started with lhcb-lcg-dev4#352
• [2017-11-22 00:14] Validation started with lhcb-gaudi-head#1666
• [2017-11-22 11:00] Validation started with lhcb-gaudi-merge#320
• [2017-11-22 11:08] Validation started with lhcb-gaudi-merge#321
• [2017-11-23 00:12] Validation started with lhcb-head#1670
• [2017-11-23 00:12] Validation started with lhcb-clang-test#778
• [2017-11-23 00:13] Validation started with lhcb-lcg-dev4#353
• [2017-11-23 00:13] Validation started with lhcb-2017-patches#212
• [2017-11-23 00:14] Validation started with lhcb-gaudi-head#1667
• [2017-11-24 00:15] Validation started with lhcb-lcg-dev3#354
• [2017-11-24 00:15] Validation started with lhcb-head#1671
• [2017-11-24 00:15] Validation started with lhcb-2017-patches#213
• [2017-11-24 00:17] Validation started with lhcb-lcg-dev4#354
• [2017-11-24 00:17] Validation started with lhcb-clang-test#779
• [2017-11-24 00:19] Validation started with lhcb-gaudi-head#1668
• [2017-11-24 14:58] Validation started with lhcb-gaudi-merge#322
• [2017-11-24 18:10] Validation started with lhcb-gaudi-merge#323
• [2017-11-25 00:12] Validation started with lhcb-2017-patches#214
• [2017-11-25 00:14] Validation started with lhcb-head#1672
• [2017-11-25 00:15] Validation started with lhcb-lcg-dev3#355
• [2017-11-25 00:15] Validation started with lhcb-clang-test#780
• [2017-11-25 00:15] Validation started with lhcb-lcg-dev4#355
• [2017-11-25 00:18] Validation started with lhcb-gaudi-head#1669
• [2017-11-26 00:14] Validation started with lhcb-2017-patches#215
• [2017-11-26 00:15] Validation started with lhcb-lcg-dev4#356
• [2017-11-26 00:15] Validation started with lhcb-clang-test#781
• [2017-11-26 00:16] Validation started with lhcb-head#1673
• [2017-11-26 00:17] Validation started with lhcb-lcg-dev3#356
• [2017-11-26 00:20] Validation started with lhcb-gaudi-head#1670
• [2017-11-26 21:51] Validation started with lhcb-gaudi-merge#324
• [2017-11-27 00:13] Validation started with lhcb-2017-patches#216
• [2017-11-27 00:14] Validation started with lhcb-lcg-dev4#357
• [2017-11-27 00:15] Validation started with lhcb-clang-test#782
• [2017-11-27 00:15] Validation started with lhcb-lcg-dev3#357
• [2017-11-27 00:16] Validation started with lhcb-head#1674
• [2017-11-27 00:18] Validation started with lhcb-gaudi-head#1671
• [2017-11-27 08:15] Validation started with lhcb-gaudi-merge#326
• [2017-11-27 08:16] Validation started with lhcb-gaudi-merge#325
• [2017-11-27 13:01] Validation started with lhcb-gaudi-head#1672
• [2017-11-27 15:48] Validation started with lhcb-gaudi-head#1672
• [2017-11-28 00:16] Validation started with lhcb-lcg-dev3#358
• [2017-11-28 00:16] Validation started with lhcb-2017-patches#217
• [2017-11-28 00:16] Validation started with lhcb-clang-test#783
• [2017-11-28 00:17] Validation started with lhcb-head#1675
• [2017-11-28 00:17] Validation started with lhcb-lcg-dev4#358
• [2017-11-28 00:19] Validation started with lhcb-gaudi-head#1673
• [2017-11-28 12:17] Validation started with lhcb-gaudi-merge#327
• [2017-11-28 12:38] Validation started with lhcb-gaudi-head#1674

added 1 commit

• a86fdeb8 - Fix typo.

Compare with previous version

resolved all discussions

@apearce, reading the discussion in the related MR in LHCb: I should cherry-pick this MR into all 3 201X-patches branches, correct? it was not explicitly requested but seems best to me. Can you confirm, just to make sure I am not missing a subtlety? Thanks a lot.

merged

mentioned in commit b715c5a0

mentioned in commit 8af5af2c

mentioned in merge request !123 (merged)

Hi @apearce, I cherry-picked to 2018-patches but things did not work for 2016-patches. Trying to do things manually I noticed that I could not "cherry-pick" this MR to 2016-patches since the DaVinci Configuration.py file does not actually know about TurboConf nor has a "Turbo" property. So it seems there is much more to update there. Shall we discuss this when you have time? For now I'm proceeding with my stacks ...