Skip to content
Snippets Groups Projects

Removed non-relevant Tesla tests on 2015 data

Merged Eduardo Rodrigues requested to merge eduardo-DaVinciTests-Tesla into 2017-patches

This is the failing test because it used a private file, which has been removed from the Grid storage. FYI @sbenson, @apearce, @cattanem, @rmatev ... Let me know if you agree with this removal ...

Edited by Eduardo Rodrigues

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 0ff5d794 - Removed a second test as it relies on the output of the one just removed in the previous commit.

    Compare with previous version

  • The second commit removes the test that relies on the one just removed.

  • Eduardo Rodrigues changed title from Removed non-relevant Tesla test on 2015 data to Removed non-relevant Tesla tests on 2015 data

    changed title from Removed non-relevant Tesla test on 2015 data to Removed non-relevant Tesla tests on 2015 data

  • Eduardo Rodrigues changed the description

    changed the description

  • LGTM :thumbsup: The tests you've removed check the behaviour of 'old-style' Tesla, which we don't support for 2017 data.

  • It turns out that various other tests depend on the output of the first test removed here: ../../options/DV_2015_CaloCheck.py:IOHelper().inputFiles( ["tesla_2015_TCK.dst"] , clear=True ) ../../options/DV_2015_MuonCheck.py:IOHelper().inputFiles( ["tesla_2015_TCK.dst"] , clear=True ) ../../options/DV_2015_RichCheck.py:IOHelper().inputFiles( ["tesla_2015_TCK.dst"] , clear=True ) ../../options/DV_2015_SharedContainers.py:IOHelper().inputFiles( ["tesla_2015_TCK.dst"] , clear=True ) ../../options/DV_2015_TISTOS.py:IOHelper().inputFiles( ["tesla_2015_TCK.dst"] , clear=True ) Shall I go ahead and remove these tests too?

    Edited by Eduardo Rodrigues
  • Hi all, I wasn't sure of the exact transition date between the old and the new style, but if that was the whole of 2017 then fair enough and feel free to remove.

  • mentioned in commit db58b8cd

Please register or sign in to reply
Loading