Skip to content
Snippets Groups Projects

Update refs for Stripping32 and Stripping33

Merged Carlos Vazquez Sierra requested to merge prepare_Stripping32_Stripping33 into 2017-patches
All threads resolved!

Prepare StrippingCache and DaVinciTests with stuff from Stripping32 and Stripping33.

Edited by Carlos Vazquez Sierra

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Carlos Vazquez Sierra
  • @sreicher @erodrigu Please have a look, there is still work to be done in any case (I will continue tomorrow). Thanks!

    Edited by Carlos Vazquez Sierra
  • The test refs are missing the counters for the various Stripping lines, so I think there is something wrong with the tests.

  • Best if Stefanie cross-checks the whole thing as I'm not the expert here.

    I will wait for your green-light(s). Thanks.

  • @cvazquez, this MR has not been touched for a few days. On top of that, it's the condition sine qua non to finalise DaVinci and hence the stack on the 2017-patches branch. Can you let me know the timescale? Thanks.

  • @erodrigu sorry for this. We were requested by the end of last week to add few new lines to Stripping32 and after discussing with the OPG we decided to go back and add these lines (so that blocks this MR since I've to re-generate everything for S32). I was trying to prepare the tests on Friday and I found that problem when lb-dev'ing DV from the nightlies, so I didn't try again yet. I will try to prepare S32 with the new lines in the next two days including today, then, I'll go back to this and finalise this MR (let's say I'll try to have this ready by the end of the week being optimistic). In any case - I'm going for vacations next 3rd of August, so my priority is to finish this before leaving (even if there are problems).

    Edited by Carlos Vazquez Sierra
  • That's understood. I just wasn't aware of those additions. Thanks for the info.

  • added 1 commit

    • c4ba02fd - Replacing input LFNs with TestFileDB

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 4b9c65c1 - Add 29r2 as well to cache building

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 4d30b7ab - Replacing options file with AppConfig path

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Carlos Vazquez Sierra resolved all discussions

    resolved all discussions

  • added 1 commit

    Compare with previous version

  • Am removing the WIP since you resolved all issues-

  • Eduardo Rodrigues unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Carlos Vazquez Sierra marked as a Work In Progress

    marked as a Work In Progress

  • Carlos Vazquez Sierra changed title from Update refs for Stripping32 and Stripping33 to WIP: update refs for Stripping32 and Stripping33

    changed title from Update refs for Stripping32 and Stripping33 to WIP: update refs for Stripping32 and Stripping33

  • Wait @erodrigu , the refs are still not OK. I'm trying to produce them today. I've sent you a mail yesterday.

  • OK. The tests may fail. But would it not be better to check at least that compilation is fine?

  • Carlos Vazquez Sierra unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Carlos Vazquez Sierra changed title from WIP: update refs for Stripping32 and Stripping33 to Update refs for Stripping32 and Stripping33

    changed title from WIP: update refs for Stripping32 and Stripping33 to Update refs for Stripping32 and Stripping33

  • Ah yes, sorry, I was thinking you wanted to merge this already. I'm removing the WIP, please do not merge until I produce the correct refs.

    Edited by Carlos Vazquez Sierra
  • added 1 commit

    Compare with previous version

  • Carlos Vazquez Sierra resolved all discussions

    resolved all discussions

  • @erodrigu now I think the ref files are OK. @sreicher please cross-check. I also updated that of s29r2 since it was failing in the nightlies. After cross-checking and confirming this compiles in the nightlies and no test fails, we are done.

    Requested @bcouturi a new release of PRConfig but he'll be back the 30th.

    Edited by Carlos Vazquez Sierra
  • Cool. Fingers crossed!

  • removed assignee

  • Edited by Software for LHCb
  • added 1 commit

    Compare with previous version

  • @erodrigu @sreicher Results from the nightlies: https://lhcb-nightlies.cern.ch/nightly/lhcb-2017-patches/build/462/

    • Only s29r2 test (updated it as well since it was failing before) fails now in gcc platforms.
    • No Stripping tests fail in centOS platforms.
    • Everything fails as usual in dbg platforms.

    I propose to move on and forget about the s29r2 by now. The differences are due to a different number of warnings in the output file. We can investigate this in the future.

    Edited by Carlos Vazquez Sierra
  • OK, that's fine by me. I will then prepare the release during the day ...

  • From a very brief look, it seems to be OK.

  • PRConfig deployment done.

  • mentioned in commit 610294d6

  • Please register or sign in to reply
    Loading