Remove TrackSys from DaVinci and Tesla configurables

FYI @cattanem.

@apearce, @rmatev, I see that TrackSys is also called in the Tesla configurable. I wonder if the lines invoking TrackSys should not also be removed there? Any reason not to?

changed the description

Tesla does the same thing DaVinci did (forwarding DataType). I’d say we can remove this.

(I guess the Tesla configurable began life as a copy-paste of the DaVinci one.)

I was assuming that's how it went. OK, then I remove those lines and we check the nightlies tomorrow. Thanks.

added 1 commit

• f45b6e87 - Remove TrackSys from Tesla configurable

Compare with previous version

changed title from Remove TrackSys from DaVinci configurable to Remove TrackSys from DaVinci and Tesla configurables

• [2019-07-04 00:12] Validation started with lhcb-head#2290
• [2019-07-04 00:13] Validation started with lhcb-lcg-dev4#953
• [2019-07-04 00:14] Validation started with lhcb-lcg-dev3#945
• [2019-07-04 00:15] Validation started with lhcb-sanitizers#296
• [2019-07-04 00:16] Validation started with lhcb-gaudi-head#2306
• [2019-07-04 00:18] Validation started with lhcb-tdr-test#597
• [2019-07-04 09:23] Validation started with lhcb-head#2291
• [2019-07-04 10:30] Validation started with lhcb-gaudi-head#2307

Many new tests are now failing but that's related to Phys!576 (merged). Let's check the status tomorrow ...

The tests look good in https://lhcb-nightlies.cern.ch/nightly/lhcb-head/build/2291/ (identical to 2289 before this MR was added).

Interestingly, the test that was broken by the cleanup of TrackSys (Rec!1557 (merged)) is still broken with this MR. Which to me mean that TrackSys was setting something behind the scenes which is now using a (different) default value

In any case I think this can be merged. @erodrigu your call as to whether you blindly update the reference of the failing test or spend time trying to understand what changed. Probably not worth the effort as we'll anyway revisit all the configuration for run 3

I agree it's not worth the effort - it won't be obvious at all to track down the source of the issue as otherwise I would have caught it already - for the reason you say. I'm merging and will update the reference file.

merged

mentioned in commit 640a0803