Fix failing test_standardbasic_reco14_run test (follow up !391)

Removing the dependency of test_standardbasic_reco14_run on test_standardbasic_reco14_int, which was removed in !391 (merged).

assigned to @rmatev

added 1 commit

• 38a18288 - remove test_standardbasic_reco14_init prerequisite from test_standardbasic_reco14_run

Compare with previous version

changed title from add back missing DVTestStandardBasic.py to Fix failing test_standardbasic_reco14_run test

/ci-test --merge

Started reference and integration test builds. Once done, check the comparison of build and test results.

• [2020-04-27 11:14] Validation started with lhcb-master-mr#728
• [2020-04-28 00:15] Validation started with lhcb-head#2576

Stupid question, why do we keep the test commonparticles.test_standardbasic_reco14_run but removed commonparticles.test_standardbasic_reco14_init?

changed the description

To be fair, one should soon reconsider the location of "DaVinci" tests on master, not the least because the new DaVinci won't be doing sprucing (Phys/StrippingCache will go away, etc.). Common particles are not defined in DaVinci hence these particular tests should move elsewhere, eventually. Just a word of warning from the DPA perspective …

If you are working on this tests it might be more effective to think the whole chain to avoid a two-step procedure. Meaning, where possible, move already tests to better locations rather than just fixing them or removing just bits.

FYI @pkoppenb.

CommonParticles are in PHYS so naively I would put unit tests there. I realise that unit tests are not possible in all cases, and some tests need to be more evolved, may require an application with input data, for example. The case of CommonParticles is likely to follow in this less trivial case.

The first location that comes to my mind is Moore - it's an application, uses particles by construction, etc.

In short:

• Make tests as small, lightweight and targeted as possible.
• What we've had so far is not necessarily what we really want for the future. No need to stay attached to past code unless necessary.

added 1 commit

• fd32ebf1 - Follow up !391 (merged)

Compare with previous version

added lhcb-head label

the test is now working again in lhcb-head/2576. For now I prefer to quickly merger this follow up MR and leave reorganization for after we have a clear direction.

Sure @rmatev, makes sense. I just thought it was a good moment to chime in and raise the point I made above, for the future.

added 1 commit

• c249f12e - Remove test_standardbasic_reco14_run (follow up !391 (merged))

Compare with previous version

enabled an automatic merge when the pipeline for c249f12e succeeds

removed lhcb-head label

merged

mentioned in commit be7a6c1a

changed title from Fix failing test_standardbasic_reco14_run test to Fix failing test_standardbasic_reco14_run test (follow up !391)