Skip to content
Snippets Groups Projects

Removed most option files and added some new

Merged Patrick Koppenburg requested to merge pkoppenb-20200527-cleanup into master

I removed all option files in Phys/DaVinci that cannot run any more. They were inherited from a time when tests did not exist. I added a test file with K*mumu from Mark Whitehead. That should probably become a test.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Eduardo Rodrigues
  • Eduardo Rodrigues
  • I think it is fair to start fresh cleaning rather old examples and files. As long as we make sure that the new code will have related tests we will be good.

    I added a few comments above. Otherwise good.

  • Edited by Software for LHCb
  • added cleanup label

  • Eduardo Rodrigues mentioned in merge request !398 (merged)

    mentioned in merge request !398 (merged)

  • Unsurprisingly this no longer works now that the stripping has been removed from DaVinci. I need at least StandardParticles and some minimal selection framework would be nice. @nskidmor what is the trick? That would also help @mamartin's test fixing.

  • You can replace

    from StandardParticles import StdLooseMuons

    with

    from PhysConf.Selections import AutomaticData
    Muons = AutomaticData('Phys/StdLooseMuons/Particles')

    and then use Muons from then on.

    All the selections and combiners live in Phys and are still available.

  • added 1 commit

    • 63d1a361 - Moved test data to PRConfig. Take StdLooseMuons from dataOnDemandSvc

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading