Skip to content
Snippets Groups Projects

Removed most option files and added some new

Merged Removed most option files and added some new
pkoppenb-20200527-cleanup into master
2 unresolved threads
Merged Patrick Koppenburg requested to merge pkoppenb-20200527-cleanup into master
2 unresolved threads

I removed all option files in Phys/DaVinci that cannot run any more. They were inherited from a time when tests did not exist. I added a test file with K*mumu from Mark Whitehead. That should probably become a test.

Merge request reports

Pipeline #1686264 passed

Stage: test

Pipeline passed for 63d1a361 on pkoppenb-20200527-cleanup

Approval is optional

Merged by Patrick KoppenburgPatrick Koppenburg 4 years ago (Jun 16, 2020 7:44am UTC)

Merge details

  • Changes merged into master with cd307b3a.
  • Deleted the source branch.

Pipeline #1719092 passed

Stage: test

Pipeline passed for cd307b3a on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Eduardo Rodrigues
  • Eduardo Rodrigues
  • Eduardo Rodrigues
  • Eduardo Rodrigues
    Eduardo Rodrigues @erodrigu ·
    Maintainer

    I think it is fair to start fresh cleaning rather old examples and files. As long as we make sure that the new code will have related tests we will be good.

    I added a few comments above. Otherwise good.

  • L
    Software for LHCb @lhcbsoft ·
    Developer
    Edited by Software for LHCb
  • Eduardo Rodrigues added cleanup label

    added cleanup label

  • Eduardo Rodrigues mentioned in merge request !398 (merged)

    mentioned in merge request !398 (merged)

  • Patrick Koppenburg
    Patrick Koppenburg @pkoppenb ·
    Author Maintainer

    Unsurprisingly this no longer works now that the stripping has been removed from DaVinci. I need at least StandardParticles and some minimal selection framework would be nice. @nskidmor what is the trick? That would also help @mamartin's test fixing.

  • Nicole Skidmore
    Nicole Skidmore @nskidmor ·
    Maintainer

    You can replace

    from StandardParticles import StdLooseMuons

    with

    from PhysConf.Selections import AutomaticData
Muons = AutomaticData('Phys/StdLooseMuons/Particles')

    and then use Muons from then on.

    All the selections and combiners live in Phys and are still available.

  • Patrick Koppenburg added 1 commit

    added 1 commit

    • 63d1a361 - Moved test data to PRConfig. Take StdLooseMuons from dataOnDemandSvc

    Compare with previous version

  • Patrick Koppenburg mentioned in commit lhcb-datapkg/PRConfig@7b829561

    mentioned in commit lhcb-datapkg/PRConfig@7b829561

  • Patrick Koppenburg mentioned in merge request lhcb-datapkg/PRConfig!135 (merged)

    mentioned in merge request lhcb-datapkg/PRConfig!135 (merged)

  • Rosen Matev mentioned in commit lhcb-datapkg/PRConfig@12f2feab

    mentioned in commit lhcb-datapkg/PRConfig@12f2feab

  • Rosen Matev mentioned in commit lhcb-datapkg/PRConfig@5ef3bc25

    mentioned in commit lhcb-datapkg/PRConfig@5ef3bc25

  • Patrick Koppenburg mentioned in commit cd307b3a

    mentioned in commit cd307b3a

  • Patrick Koppenburg merged

    merged

  • Eduardo Rodrigues
    Eduardo Rodrigues @erodrigu ·
    Maintainer

    Not a massive issue, @pkoppenb, but you forgot to deal with all my comments above? Else you did make the changes but nothing got resolved in the threads above ;-).

  • Patrick Koppenburg
    Patrick Koppenburg @pkoppenb ·
    Author Maintainer

    You mean the comments in DaVinci-Example.py. You are right. I fixed them, got into git trouble and now it seems we are back to original. I'll fix that.

  • Eduardo Rodrigues mentioned in merge request !405 (merged)

    mentioned in merge request !405 (merged)

  • Davide Fazzini mentioned in merge request Bender!204 (merged)

    mentioned in merge request Bender!204 (merged)

  • Rosen Matev added Configuration label

    added Configuration label

  • Rosen Matev mentioned in merge request !406 (merged)

    mentioned in merge request !406 (merged)

    • Please register or sign in to reply