Skip to content
Snippets Groups Projects

Fixes for python3

Merged Mark Smith requested to merge run2_python3 into run2-patches
Edited by Marco Cattaneo

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Marco Cattaneo added 1 commit

    added 1 commit

    • 7087364a - Apply Eduardos suggestion to fix merge-small-files test

    Compare with previous version

  • Marco Cattaneo resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • Eduardo Rodrigues changed the description

    changed the description

  • Author Maintainer

    So I think we cannot go any further until !429 (merged) is merged. I don't think python3 can open the db files from the StrippingArchive produced with python2. A quick google suggests python3 shelve can't open ones created with python2.

  • Eduardo Rodrigues changed the description

    changed the description

    • Resolved by Marco Cattaneo

      How far are you from being able to merge !429 (merged)? If there is some real issue such as the one you mention then we have to live with it, right? In good CI tools such as pytest you can easily skip certain tests based on conditions (not Python 2, etc.). Thanks for the investigation.

  • Marco Cattaneo added 8 commits

    added 8 commits

    • f14b99b3...a20c04dd - 4 commits from branch run2-patches
    • 4e671d16 - update tests
    • 38a5ab19 - python 3 compatibility
    • a917470d - Update CheckFSRs.py to use subprocess.check_output instead of subprocess.getoutput
    • c324af8d - Apply Eduardos suggestion to fix merge-small-files test

    Compare with previous version

  • Marco Cattaneo added 3 commits

    added 3 commits

    • 718c103f - python 3 compatibility
    • 7e16d2a8 - Update CheckFSRs.py to use subprocess.check_output instead of subprocess.getoutput
    • 8523e3cd - Apply Eduardos suggestion to fix merge-small-files test

    Compare with previous version

  • Marco Cattaneo changed title from run2-patches python3 to Fixes for python3

    changed title from run2-patches python3 to Fixes for python3

  • Marco Cattaneo resolved all threads

    resolved all threads

  • Edited by Software for LHCb
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading