Fix DaVinci tests

New tests of ThOr functors. Also adapted those that rely on Analysis!791 (merged) (hence needs this MR).

Other tests are also fixed to match what is going on in lhcb-run3-cleanup

added lhcb-run3-cleanup label

added 1 commit

• a54f36ce - Fixed formatting

Compare with previous version

/ci-test --merge Analysis!791 (merged)

added ci-test-triggered label

• [2021-04-30 18:14] Validation started with lhcb-master-mr#2266
• [2021-05-01 01:29] Validation started with lhcb-run3-cleanup#200
• [2021-05-04 00:33] Validation started with lhcb-run3-cleanup#201
• [2021-05-05 00:56] Validation started with lhcb-run3-cleanup#202

added 1 commit

• 92c0f9c9 - Remove use of TMVA

Compare with previous version

Removed TMVA dependency in algorithms_pyconf.py as it was making tests to fail, following Analysis!783 (merged) . @erodrigu

OK, probably something not needed in the end in DaVinci, and we will use "what comes new". FYI @mamartin. BTW, also the lines

    LoKi__Hybrid__DictOfFunctors as DictOfFunctors,
    LoKi__Hybrid__DictValue as DictValue,

can then me removed, I think.

Done. Obviously we'll restore that when needed.

marked this merge request as ready

added 1 commit

• 76397847 - Fixed formatting

Compare with previous version

added 1 commit

• d696f1e2 - Update DVTestFunctors.py

Compare with previous version

added 1 commit

• 4e8173d7 - Update DVTestFunctors.py

Compare with previous version

@nnolte at !538 (diffs) I do

    daughters_code = {"K+": F.PID_K > 0, "K-": F.PID_K > 0}

but in the statistics I see

TightD02KK                                                     INFO Number of counters : 4
 |    Counter                                      |     #     |    sum     | mean/eff^* | rms/err^*  |     min     |     max     |
 |*"# passed K+ cut"                               |      2210 |       1131 |( 51.17647 +- 1.063295)% |
 |*"# passed K- cut"                               |      2210 |       1079 |( 48.82353 +- 1.063295)% |
 |*"# passed comb12 cut"                           |     67861 |       2152 |( 3.171188 +- 0.06726717)% |
 |*"# passed mother cut"                           |      2152 |       2126 |( 98.79182 +- 0.2355076)% |

so all K pass either cut. I rather expect something like 200 passing kaons for each cut. Is PID_K not working or am I using it wrongly?

added 1 commit

• 0bbe639e - actually apply the K cut

Compare with previous version

added 1 commit

• a41e32f7 - Update DVTestFunctors.py

Compare with previous version

added 1 commit

• 7b888b6b - Update DVTestFunctors.py

Compare with previous version

added 1 commit

• d31db4aa - Remove PrintDecayTree test from DaVinciTests. There is one in DaVinciExamples

Compare with previous version

Note @erodrigu : we each wrote an almost identical test in two different packages. I removed mine as I think it's better to have it in DaVinciExamples.

• [2021-05-06 00:50] Validation started with lhcb-run3-cleanup#203
• [2021-05-07 00:54] Validation started with lhcb-run3-cleanup#204
• [2021-05-08 01:12] Validation started with lhcb-run3-cleanup#205
• [2021-05-10 00:14] Validation started with lhcb-run3-cleanup#206
• [2021-05-11 00:44] Validation started with lhcb-run3-cleanup#207
• [2021-05-12 01:06] Validation started with lhcb-run3-cleanup#208
• [2021-05-12 13:56] Validation started with lhcb-master-mr#2305
• [2021-05-13 01:02] Validation started with lhcb-run3-cleanup#209
• [2021-05-14 01:16] Validation started with lhcb-run3-cleanup#210
• [2021-05-16 00:31] Validation started with lhcb-run3-cleanup#211
• [2021-05-18 01:11] Validation started with lhcb-run3-cleanup#212
• [2021-05-19 01:00] Validation started with lhcb-run3-cleanup#213
• [2021-05-20 01:11] Validation started with lhcb-run3-cleanup#214
• [2021-05-21 01:24] Validation started with lhcb-run3-cleanup#215
• [2021-05-22 01:27] Validation started with lhcb-run3-cleanup#216
• [2021-05-25 00:46] Validation started with lhcb-run3-cleanup#217
• [2021-05-26 01:21] Validation started with lhcb-run3-cleanup#218
• [2021-05-26 13:38] Validation started with lhcb-master-mr#2374
• [2021-05-26 17:43] Validation started with lhcb-master-mr#2380
• [2021-05-27 01:16] Validation started with lhcb-run3-cleanup#219
• [2021-05-27 12:18] Validation started with lhcb-master-mr#2382
• [2021-05-28 01:30] Validation started with lhcb-run3-cleanup#220
• [2021-05-29 01:45] Validation started with lhcb-run3-cleanup#221
• [2021-05-30 00:48] Validation started with lhcb-run3-cleanup#222
• [2021-05-31 00:34] Validation started with lhcb-run3-cleanup#223
• [2021-06-01 01:18] Validation started with lhcb-run3-cleanup#224
• [2021-06-02 01:15] Validation started with lhcb-run3-cleanup#225

mentioned in merge request Rec!2420 (merged)

mentioned in merge request !539 (merged)

added 1 commit

• bbe49a63 - Fix tests

Compare with previous version

added 1 commit

• c331abae - reverted a file

Compare with previous version

added 1 commit

• d1353e4b - Update DaVinciExamples/python/DaVinciExamples/debugging/example-PrintDecayTree.py

Compare with previous version

added 1 commit

• 0d3f8598 - Update DaVinciExamples/python/DaVinciExamples/tupling/example-tupling-basic.py

Compare with previous version

Tests fail due to PrintDecay. Fixing.

added 1 commit

• 51fe1ea4 - Fix PrintDecay test

Compare with previous version

added 1 commit

• c981927e - Update example-PrintDecayTree.py

Compare with previous version

added 1 commit

• 542d9608 - Update example-PrintDecayTree.py

Compare with previous version

mentioned in merge request Analysis!791 (merged)

added 1 commit

• 08af1f28 - Fix tests following MR Phys!933 (merged)

Compare with previous version

added 1 commit

• ac824bf8 - Update DVTestFunctors.py

Compare with previous version

mentioned in merge request Analysis!792 (merged)

added 1 commit

• 7f3cf530 - Update DVTestFunctors.py

Compare with previous version

changed the description

added 1 commit

• 7335344a - Fix PrintDecayTree inputs

Compare with previous version

changed title from New functor test to Fix DaVinci tests

changed the description

added 1 commit

• 2525186f - Fix 2 tests

Compare with previous version

• [2021-06-03 00:58] Validation started with lhcb-run3-cleanup#226
• [2021-06-04 00:58] Validation started with lhcb-run3-cleanup#227
• [2021-06-04 10:32] Validation started with lhcb-master-mr#2422
• [2021-06-05 01:09] Validation started with lhcb-run3-cleanup#228

Everything is happy in lhcb-run3-cleanup. I am going to ci-test all MRs and merge. @erodrigu please have a look if you wish.

/ci-test --merge Analysis!791 (merged) Analysis!783 (merged)

Started reference and integration test builds. Once done, check the comparison of build and test results.

Throughput Test Moore_hlt2_reco_baseline: 148.4 Events/s -- change of 0.03% vs. reference

Throughput Test Moore_hlt2_fastest_reco: 353.1 Events/s -- change of 0.00% vs. reference

Throughput Test Moore_hlt1_pp_default: 27533.1 Events/s -- change of 0.00% vs. reference

resolved all threads

Apologies, I'm not finding that much time to look at all DaVinci MRs :S. But I certainly trust you! And we can always revise later down the line the test suite.

mentioned in commit 369be14f

merged