Skip to content
Snippets Groups Projects

Adapt to ThOr functor and algorithm naming changes

Merged Alex Pearce requested to merge apearce-particle-functor-cleanup into master
All threads resolved!

Follows the changes in Rec!2456 (merged) and Phys!945 (merged). Relevant here are changes to some test options:

  • MASS functor no longer needs to be given mass hypotheses.
  • Combiner changes:
    • Property names are different (Comb12Cut -> CombinationCut).
    • Accepts a single decay descriptor.
    • Accepts one input container per child.

I also took the liberty of making a few clean-ups (moving imports to the top of the file, removing unused imports) and updated the test reference. Note that the number of accepted candidates has not changed.

Requires Rec!2456 (merged) and Phys!945 (merged). Related to Moore!862 (merged) and MooreAnalysis!39 (merged).

Edited by Alex Pearce

Merge request reports

Pipeline #2730373 passed

Pipeline passed for 3a27ff55 on apearce-particle-functor-cleanup

Merged by Patrick KoppenburgPatrick Koppenburg 3 years ago (Jun 30, 2021 11:28am UTC)

Merge details

  • Changes merged into master with 070f6667 (commits were squashed).
  • Deleted the source branch.

Pipeline #2774909 passed

Pipeline passed for 070f6667 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alex Pearce mentioned in merge request Moore!862 (merged)

    mentioned in merge request Moore!862 (merged)

  • Alex Pearce resolved all threads

    resolved all threads

  • Alex Pearce added 1 commit

    added 1 commit

    • 3a27ff55 - Adapt to ThOr functor and algorithm naming changes.

    Compare with previous version

  • Thanks. Added lhcb-run3-cleanup to this and the two other MR so I get it for my own developments.

  • Edited by Software for LHCb
  • assigned to @ziyiw

  • added lhcb-head label

  • removed lhcb-head label

  • Alex Pearce mentioned in merge request Phys!945 (merged)

    mentioned in merge request Phys!945 (merged)

  • Alex Pearce mentioned in merge request Rec!2456 (merged)

    mentioned in merge request Rec!2456 (merged)

  • mentioned in merge request MooreAnalysis!39 (merged)

  • Alex Pearce changed the description

    changed the description

  • Rosen Matev approved this merge request

    approved this merge request

  • unassigned @ziyiw

  • added all-slots label

  • Patrick Koppenburg resolved all threads

    resolved all threads

  • Patrick Koppenburg resolved all threads

    resolved all threads

  • mentioned in commit 070f6667

  • Please register or sign in to reply
    Loading