Lint/clean-up/fix new configuration

FYI @dfazzini and @mamartin.

Relates to DPA task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/137.

added Configuration label

added 1 commit

• 66bc27a3 - Fixed formatting

Compare with previous version

changed title from Lint/clean-up/fix all new configuration to Lint/clean-up/fix new configuration

So now all Python files (except Configuration.py, about to be removed) are linted and fixed for unnecessary or missing imports, small issues.

/ci-test --merge Analysis!806 (merged)

added ci-test-triggered label

• [2021-07-13 16:02] Validation started with lhcb-master-mr#2567
• [2021-07-14 10:46] Validation started with lhcb-master-mr#2569

added 1 commit

• 2e6b1103 - Start to lint DaVinciTests. Still many flake8 warnings to deal with at some point ...

Compare with previous version

OK, fixed a funny error I did not foresee and started to clean-up DaVinciTests. But I won't finalise that here as I'm not sure we will be keeping all those files in there and do not want to do work for nothing at this stage.

/ci-test --merge Analysis!806 (merged)

Started reference and integration test builds. Once done, check the comparison of build and test results.

added 1 commit

• b1597e66 - Fixed formatting

Compare with previous version

mentioned in merge request Analysis!806 (merged)

Does lint force us to write less readable code? I like some spaces.

There are places where you will for sure see differences wrt your own preferences. And Black, the official PSF tool, even has more differences, I believe. This being said, it all goes in the direction of Python standard conventions and is not too bad in the end. To me the fact that flake8 and others find so many little issues in the code outweights by a large amount the few cosmetic changes I would not do myself (same as you would not do, from what I gather).

@pkoppenb, this and the related MR seem ready to go - CI happy.

mentioned in commit c16c7c4f

merged