Skip to content
Snippets Groups Projects

Remove old davinci configurable and related tests

Merged Davide Fazzini requested to merge remove-old-davinci-configurable into master

Update all the scripts to the new DaVinci configuration. Removing old DaVinci Configuration.py and the related option files and qmtests not used with the new Configuration. Removing also the following qmtests:

  • packing.qms/test_dstunpacking_upgrade.qmt: it will be replaced by a new test with !573 (merged).
  • davinci.qms/gaudipython_algs.qmt: due to some overlaps with the other qmtests
  • io.qms/test_write_dst.qmt: it will be replaced in a future dedicated qmtest

Closes https://gitlab.cern.ch/lhcb-dpa/project/-/issues/137.

Edited by Davide Fazzini

Merge request reports

Pipeline #2974647 passed

Pipeline passed for 2b095324 on remove-old-davinci-configurable

Merged by Patrick KoppenburgPatrick Koppenburg 3 years ago (Sep 2, 2021 8:46am UTC)

Loading

Pipeline #2980097 passed

Pipeline passed for 6a182a3a on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Davide Fazzini

      @dfazzini, I hardly ever find it a good idea to broaden the scope of MRs. In this instance you are doing quite a bit more than getting rid of the old Configurable. In particular, you are also modifying various scripts in DaVinciExamples, which are perfectly valid scripts based on the simplest PyConf "structures". We can discuss if updates are needed there but please do not edit those files in this removal MR.

  • Eduardo Rodrigues
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading