Resolve "Tupling test running on spruced output"
Closes #6 (closed)
Merge request reports
Activity
assigned to @dfazzini
added Configuration label
I see nothing shocking :) but @nskidmor should have a look.
Resolved by Davide FazziniI still have some problems when calling the read_hlt2 function. I receive the following error:
TypeError: The list of children may only contain instances of types Algorithm or CompositeNode
I think this is due to the fact that the functions implemented in GaudiConf.reading are not fully compatible with PyConf.Edited by Davide Fazzini- Last reply by Davide Fazzini
mentioned in issue LHCb#149 (closed)
mentioned in merge request !568 (merged)
- Resolved by Davide Fazzini
I have two conceptual questions.
Currently the unpacking algorithms are added to the control flow at the very beginning. This probably means that they are run in every event. No matter if the event contained the desired sprucing candidate or not. I think this should not be necessary if the unpacking would be functional (at least use data handles). Then PyConf, HiveDataBrokerSvc and HLTControlFlowMgr could setup the data flow automatically. Are there any plans for fixing that? Does LHCb!3192 (merged) address this issue?
The unpacking is quite time consuming (LHCb!3192 (merged)). Is there any plan for something like the EventPreFilters in DaVinci?
- Last reply by Eduardo Rodrigues
-
Yes I would also love to see the whole thingy functional. The pointers you provide help as otherwise, myself for example, I would not know who precisely is improving the packers and on what timescale.
I don't quite see at this point if we need EventPreFilters, or not. There might be a more elegant solution connecting better with the PyConf framework and the kind of filters as in selection lines. To be discussed, I guess. The one thing I would really like to avoid is many ways to do the same; better focus on a single and efficient way. This needs some thought beyond this MR ...
added 1 commit
- a2a2bb56 - fix call to upack algorithms according to LHCb 3222 MR
- Resolved by Davide Fazzini
@nskidmor, @rmatev I receive the following error when calling the createODIN() method on the spruced sample:
createODIN ERROR Cannot retrieve /Event/DAQ/RawBanks/ODIN from transient store. createODIN ERROR Maximum number of errors ( 'ErrorMax':1) reached. HLTControlFlowMgr FATAL Event failed in Node createODIN/createODINAll the other locations are correctly retrieved so maybe there is an error in the way I call the function. createODIN() is called in Phys/DaVinci/python/DaVinci/algorithms.py as:
createODIN(RawBanks=default_raw_event(['ODIN']))Is this correct or should I use a different raw banks location?
- Last reply by Davide Fazzini
@dfazzini great to see this coming together! Looks great :)
added 1 commit
- 844ad6cf - Update DaVinciTests/tests/options/option_davinci_sprucing.py,...
- Resolved by Davide Fazzini
/ci-test --merge
added ci-test-triggered label
- [2021-09-11 17:30] Validation started with lhcb-master-mr#2873
- [2021-09-12 20:06] Validation started with lhcb-master-mr#2877
Edited by Software for LHCbadded 22 commits
-
0843cd84...a5201681 - 4 commits from branch
master - 68c9ecfb - adding hlt2read functionality
- 9e7aab85 - Fixing pipeline
- 02cc185c - Fixed formatting
- 7a35b3eb - small changes
- 8efd11ca - create function to configure HltANNSvc
- 4fcbe238 - fix order of DV options
- 5c386796 - Fixed formatting
- 04ebbf34 - Fixing linting
- 5eb1d940 - adding DaVinci option for the event stream
- b76d71df - Fixed formatting
- c291589e - Fixing linting
- 74b98283 - Fixed formatting
- c91557d6 - fix call to upack algorithms according to LHCb 3222 MR
- 56c357a4 - Fixed formatting
- ecca1a10 - Apply 1 suggestion(s) to 1 file(s)
- d019d5a9 - Update DaVinciTests/tests/options/option_davinci_sprucing.py,...
- db1a0da3 - Fixed formatting
- 737644f5 - changing name for the hlt_annsvc_pol option
Toggle commit list-
0843cd84...a5201681 - 4 commits from branch
- Resolved by Davide Fazzini
/ci-test --merge
added 1 commit
- 168ed7aa - add function to read .json files from eos locations
- Resolved by Software for LHCb
/ci-test --merge
- [2021-09-13 12:41] Validation started with lhcb-master-mr#2879