Adding function to return a list of filters and tupling algorithms
Implementing a new function to make easier the configuration of a Funtuple algorithm in DaVinci, as suggested by @sstahl in !577 (merged) (comment 4941169). This new function, named 'ConfiguredFuntuple', combines the instatiation of:
-
HDRfilter
: to select only the events passing a specific set of trigger lines, -
make_data_with_FetchDataFromFile
: to obtain the correct DataHandle object, -
Funtuple
: object containing all the branches and variables defined by the user.
This MR solves one of the two points described in #14 (closed).
Merge request reports
Activity
added DPA-WP3 label
assigned to @dfazzini
added 1 commit
- 82c6daf0 - add 'ConfiguredFuntuple' function and related qmtest
added new feature label
- Resolved by Davide Fazzini
Looks nice. Does this handle cases as !569 (merged) where FunTuple has a dependency on DecayTreeFitterAlg ?
- Resolved by Eduardo Rodrigues
Since you pinged me as a reviewer - I have to say that I'm not convinced by the need for this wrapper that will only typically add a filter when instantiating FunTuple. And many users won't need filters either, I imagine. I know that you are going to say we should avoid having every user adding boilerplate business to their scripts but this one seems like something you would want the user to be clear about. This here reminds me of all the configuredXXX helpers for tracking; there it was most probably necessary because many things needed to be done "behind the scenes" correctly. I don't see a big benefit here.
One point that is particularly ugly, which triggered me immediately towards this comment, is the fact that you then have to pass the DaVinci (big-ish) options object to configure the FunTuple instance. It's coupling far too much and hence looks non-ideal.
Sorry, my 2 cents.
- Resolved by Eduardo Rodrigues
- Resolved by Davide Fazzini
- Resolved by Davide Fazzini
- Resolved by Eduardo Rodrigues
- Resolved by Davide Fazzini
- Resolved by Davide Fazzini
- Resolved by Davide Fazzini
- Resolved by Davide Fazzini
- Resolved by Eduardo Rodrigues
Maybe this can still go in for the DaVinci release next week for tests during FEST, @pkoppenb?
added ci-test-triggered label
- [2021-11-28 15:21] Validation started with lhcb-master-mr#3208
- Resolved by Eduardo Rodrigues
Either here or in a to-do: make sure some (or all) examples in DaVinciExamples use this. Now the example is hidden in DaVinciTests.
mentioned in commit 9f3c3a94
mentioned in issue #14 (closed)