Skip to content
Snippets Groups Projects

Resolve "Overriding options in davinci script depends on order of special flag overwrite_data_options" & bug with bool passed via command line

Fixing two bugs related to setting boolean properties by command line:

  • value passed via command line are always interpreted as string, so a conversion is applied when the properties are set
  • 'overwrite_data_options' properties has to be set before any other one in order to know if the data options properties can be overriden in the job.

In addition the name of the 'overwrite_data_options' property has changed into 'override_data_options'

Closes #22 (closed)

Edited by Davide Fazzini

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Davide Fazzini

      Thinking further about this special option - I wonder if it would make more sense to have it a command-line option displayed with davinci run-mc --help as for example --inputfiledb. Indeed it seems more natural as a command option kind of saying "hey, I'm passing in some job options on the command line that are meant to override whatever values the options have in the option files" than as a DaVinci option itself along DataType and alike. Happy to make this a follow-up since this change would involve various changes.

  • Davide Fazzini resolved all threads

    resolved all threads

  • Davide Fazzini added 1 commit

    added 1 commit

    • 72f4a562 - add check for correct value of boolean passed via command line

    Compare with previous version

  • Davide Fazzini added 1 commit

    added 1 commit

    Compare with previous version

  • Davide Fazzini resolved all threads

    resolved all threads

  • Davide Fazzini added 1 commit

    added 1 commit

    Compare with previous version

  • Edited by Software for LHCb
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading