Resolve "Overriding options in davinci script depends on order of special flag overwrite_data_options" & bug with bool passed via command line
Fixing two bugs related to setting boolean properties by command line:
- value passed via command line are always interpreted as string, so a conversion is applied when the properties are set
- 'overwrite_data_options' properties has to be set before any other one in order to know if the data options properties can be overriden in the job.
In addition the name of the 'overwrite_data_options' property has changed into 'override_data_options'
Closes #22 (closed)
Merge request reports
Activity
added Configuration bug labels
assigned to @dfazzini
requested review from @erodrigu
I will check this asap. Can you in any case rebase to pick up the tests at !608 (merged) where we should add one with the "wrong order" to ensure the buglet is fixed? Thanks.
- Resolved by Davide Fazzini
- Resolved by Davide Fazzini
Thinking further about this special option - I wonder if it would make more sense to have it a command-line option displayed with
davinci run-mc --help
as for example--inputfiledb
. Indeed it seems more natural as a command option kind of saying "hey, I'm passing in some job options on the command line that are meant to override whatever values the options have in the option files" than as a DaVinci option itself along DataType and alike. Happy to make this a follow-up since this change would involve various changes.
added 1 commit
- 72f4a562 - add check for correct value of boolean passed via command line
- Resolved by Software for LHCb
/ci-test --merge
added ci-test-triggered label
- [2021-12-14 17:00] Validation started with lhcb-master-mr#3345
- [2021-12-14 18:52] Validation started with lhcb-master-mr#3347
Edited by Software for LHCb