Checks for ERROR and FATAL in all tests

Addresses #25 (closed)

More checks for FATAL and ERROR are added in all tests.

Needs Analysis!842 (merged)

assigned to @pkoppenb

added DPA-WP3 label

added bug fix label

added testing label

mentioned in issue #25 (closed)

The test of this MR fails when run on master (as it should) but not when built with Analysis!842 (merged) . See #25 (comment 5105346).

changed the description

requested review from @nskidmor and @erodrigu

Looks good. We should have such a check in all tests, if not already the case.

I'll have a look tomorrow.

approved this merge request

It might not apply here but there is a peculiarity in GaudiPython that the ERROR message cannot start with "ERROR", see https://gitlab.cern.ch/lhcb/Moore/-/blob/master/Hlt/Hlt2Conf/tests/options/spruce_check.py#L117.

Can you "make" it fail successfully?

added lhcb-run3-cleanup label

You mean? Yes, it failed first and then passed when I rebuilt FunTuple.

• [2021-12-17 00:58] Validation started with lhcb-run3-cleanup#398

added 1 commit

• 46ce50a4 - Add search for ERROR in all tests

Compare with previous version

changed title from More checks in All functors test to Checks for ERROR and FATAL in all test

changed the description

@erodrigu I now hacked all tests.

changed title from Checks for ERROR and FATAL in all test to Checks for ERROR and FATAL in all tests

merged