Storing event info (trigger and odin) with FunTuple

requested review from @pkoppenb and @erodrigu

assigned to @amathad

mentioned in merge request Analysis!867 (merged)

mentioned in merge request Rec!2737 (closed)

Currently the event info functors are added to FunTuple by defining explicitly an “EVENT” branch, see code below (from @sstahl suggestion). The code outputs variables named "EVENT_NUMBER", "EVENT_RUNNUMBER", "D0_PT".

We don’t want users to make such a branch explicitly but handle the "EVENT" branch like the special branch "ALL", where we add an "EVENT" branch with one of the decay descriptors behind the scenes (preferably head but I don't think it matters (?).)

#define branches: “EVENT” should be a special keyword like “ALL”? 
branches = {
    "EVENT": "[D0 -> K- pi+]CC", 
    "D0": "[D0 -> K- pi+]CC"}  

#define event info 
evt_vars = {
    "NUMBER": F.EVENT_INFO(F.EVENTNUMBER, ODIN=odin),
    "RUNNUMBER": F.EVENT_INFO(F.RUNNUMBER, ODIN=odin)
}

variables = {
    "EVENT": FunctorCollections(evt_variables),     
    “D0”: FunctorCollections({"PT": F.PT})
}

changed the description

added 1 commit

ad86d253 - small fix

Compare with previous version

added 1 commit

1e1b07cf - Fixed formatting

Compare with previous version

Currently, I am getting ODIN DataHandle from my own producer algorithm for testing, but I want a PyConf compatible ODIN DataHandle pointing to the correct ones (@dfazzini could you help me get that?). Also need one for DecReport (however the corresponding functor to line decision hasn't been written yet).

Shouldn't that be added to all examples and tests?

added lhcb-run3-cleanup label

Hi @amathad could you please also check which functors can be uncommented/added in DaVinciExamples/python/DaVinciExamples/tupling/example-tupling-AllFunctors.py thanks to this MR?

added 10 commits

1e1b07cf...d212ccb9 - 4 commits from branch master
3433ee1a - add runnumber and eventnumber
2355009d - event info
e6e1b850 - event info
97b34a78 - small fix
b5e774e7 - Fixed formatting
622265f2 - Merge branch 'AM_eventinfo' of ssh://gitlab.cern.ch:7999/lhcb/DaVinci into AM_eventinfo

Compare with previous version

added 1 commit

24ffe12d - update functors

Compare with previous version

[2022-02-18 01:03] Validation started with lhcb-run3-cleanup#440
[2022-02-19 00:43] Validation started with lhcb-run3-cleanup#441
[2022-02-20 00:25] Validation started with lhcb-run3-cleanup#442
[2022-02-22 00:37] Validation started with lhcb-run3-cleanup#443
[2022-02-23 00:43] Validation started with lhcb-run3-cleanup#444
[2022-02-24 01:05] Validation started with lhcb-run3-cleanup#445
[2022-02-25 01:19] Validation started with lhcb-run3-cleanup#446

mentioned in merge request Rec!2747 (merged)

Storing event info (trigger and odin) with FunTuple

Merge request reports

Activity