Introduce DaVinci tutorials
Move the staterkit
tutorials folder into master. Note that each example has objectives and showcases certain features (see README.md
). Work towards DPA grand task https://gitlab.cern.ch/lhcb-dpa/project/-/issues/102. @mamartin : Could be helpful/linked to documentation.
To be tested with: !705 (merged) and Analysis!892 (merged)
Merge request reports
Activity
added DPA-WP3 Documentation Tuples labels
- Resolved by Abhijit Mathad
You already know most of my thoughts on the business but let me list a couple since this seems the most appropriate place:
-
I'm obviously in no way against tutorials, on the contrary! Excellent to see this material. But ...
-
As-is this new stuff is very brittle and I would be very much against examples that are not CI tested. Forget about the non-ideal practices we've followed in several areas in the past. Now we want to be better and safer :-). Everything should be tested in a tests folder.
-
We need to think carefully about "our own" examples and any examples/tutorials part of the Starterkit, to avoid as much duplication as possible since that implies extra maintenance and more ways to get material outdated. What's the opinion of our Starterkit colleagues and this material and how do they see using it in their courses? It would be easier if we all converge on a consensus forward. Happy if you tag them here.
-
On your comment related to DaVinci documentation on the/a site - see my comments at !647 (comment 5396945) :-). Again, the grand idea is to have a centralised place for "everything" where relevant. That's as often a bit more work at the start but I'm convinced it will pay off in the medium term.
- Resolved by Abhijit Mathad
I tried to git lb-checkout this package but cannot. DaVinciTutorials should be a proper cmake package with
- a python directory containing the examples
- a tests directory as Eduardo requests
- a CMakeLists.txt even if trivial
Thanks
- Resolved by Abhijit Mathad
Any chance this could make the DaVinci release early next week? (I don't want to spoil your Easter break).
added 2 commits
added 14 commits
-
1462eda0...73431bdc - 12 commits from branch
master
- 6c7fd1b8 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/DaVinci into AM_tutorials
- 54570776 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/DaVinci into AM_tutorials
-
1462eda0...73431bdc - 12 commits from branch
- Resolved by Abhijit Mathad
Any progress on this?
- Resolved by Abhijit Mathad
added 6 commits
-
54570776...50241711 - 4 commits from branch
master
- 9844ff98 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/DaVinci into AM_tutorials
- 3d5af67d - update tutorials
-
54570776...50241711 - 4 commits from branch