Update add_filter with checks and append suffix Decision if necessary

Driven by the comment from @pkoppenb here this MR introduces checks to add_filter and adds suffix Decision if not present in the line name.

This would avoid mistakes by users who have to type Decision explicitly. So the code would change from:

filter = add_filter("filter_name",f"HLT_PASS('{line_name}Decision', '{line_name2}Decision')")

to

filter = add_filter("filter_name",f"HLT_PASS('{line_name}', '{line_name2}')")

To be tested with: Analysis!892 (merged)

added Configuration DPA-WP3 enhancement labels

requested review from @erodrigu, @pkoppenb, and @dfazzini

assigned to @amathad

added 1 commit

• 6fb21622 - Fixed formatting

Compare with previous version

changed the description

The tests of this change will be in tutorial MR (!682 (merged)) but I haven't changed anything in DaVinciExamples or DaVinciTutorials.

Perhaps we want to at-least change DaVinciExamples, to show users that they need not specify Decision suffix?

Hey, can the various lines and check not be simplfied with a regex a bit like https://gitlab.cern.ch/lhcb/Moore/-/blob/master/Hlt/Moore/python/Moore/config.py#L39-41? I confess I did not try hard but it seems doable?

resolved all threads

resolved all threads

added 1 commit

• 5d305f40 - eduardo's comment

Compare with previous version

approved this merge request

approved this merge request

added 1 commit

• e951fded - update examples

Compare with previous version

added 1 commit

• 0b3eae56 - Fixed formatting

Compare with previous version

@dfazzini : This version of add_filter always require that there is HLT_PASS and builds a new one with the Decision suffix added. Therefore, it clashes with an existing test i.e. test_add_void_filter. Is this okay? Can this test be removed?

changed the description

mentioned in merge request Analysis!892 (merged)

mentioned in merge request !682 (merged)