Make "process" a required input and configure pyconf functions globally once with user input
Closes #59 (closed) and closes #74 (closed).
-
Make process a required input. -
Make "options.process" as the default input to algorithms (e.g. truth matching). -
Make process a required input to truth-matching algorithm (related to issue: #62 (closed)) and also set correct root-in-tes for Turbo
process.
To be tested with: LHCb!3806 (merged), Moore!1812 (merged) and Analysis!914 (merged)
Edited by Abhijit Mathad
Merge request reports
Activity
Filter activity
added Configuration DPA-WP3 labels
- Resolved by Abhijit Mathad
mentioned in merge request !716 (merged)
- Resolved by Abhijit Mathad
Regarding the first point, I think we can implement in DV a function similar to validate_input, for checking the DV-specific properties (since
process
could not be shared in other application as Gauss). So I am thinking to something like:def validate_input(values): if not values.get("process"): raise ValueError(f"'process' is a required property for running DaVinci. Available values: 'Spruce', 'Turbo', 'Hlt2'.") return values
This function could be call inside make_config before invoking the DV master function.
marked the checklist item Make process a required input. (Could you help me with this @dfazzini ?) as completed
added 12 commits
-
cb0d0a44...1e709d7a - 10 commits from branch
master
- a7ca5dbc - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/DaVinci into AM_process
- 7ae71994 - make process required
-
cb0d0a44...1e709d7a - 10 commits from branch
@pkoppenb : This is ready to be tested.
- Resolved by Abhijit Mathad
/ci-test
Please register or sign in to reply