Skip to content
Snippets Groups Projects

Make "process" a required input and configure pyconf functions globally once with user input

Merged Abhijit Mathad requested to merge AM_process into master

Closes #59 (closed) and closes #74 (closed).

  • Make process a required input.
  • Make "options.process" as the default input to algorithms (e.g. truth matching).
  • Make process a required input to truth-matching algorithm (related to issue: #62 (closed)) and also set correct root-in-tes for Turbo process.

To be tested with: LHCb!3806 (merged), Moore!1812 (merged) and Analysis!914 (merged)

Edited by Abhijit Mathad

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Abhijit Mathad changed the description

    changed the description

  • Abhijit Mathad mentioned in merge request !716 (merged)

    mentioned in merge request !716 (merged)

  • Abhijit Mathad changed the description

    changed the description

  • Abhijit Mathad added 1 commit

    added 1 commit

    Compare with previous version

    • Resolved by Abhijit Mathad

      Regarding the first point, I think we can implement in DV a function similar to validate_input, for checking the DV-specific properties (since process could not be shared in other application as Gauss). So I am thinking to something like:

      def validate_input(values):
         if not values.get("process"):
           raise ValueError(f"'process' is a required property for running DaVinci. Available values: 'Spruce', 'Turbo', 'Hlt2'.")
         return values

      This function could be call inside make_config before invoking the DV master function.

  • Abhijit Mathad marked the checklist item Make process a required input. (Could you help me with this @dfazzini ?) as completed

    marked the checklist item Make process a required input. (Could you help me with this @dfazzini ?) as completed

  • Abhijit Mathad changed the description

    changed the description

  • Abhijit Mathad added 12 commits

    added 12 commits

    Compare with previous version

  • Abhijit Mathad resolved all threads

    resolved all threads

  • Abhijit Mathad marked this merge request as ready

    marked this merge request as ready

  • Author Developer

    @pkoppenb : This is ready to be tested.

  • I like it when hard-coded strings go away.

  • Patrick Koppenburg approved this merge request

    approved this merge request

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading