Follow-up MR from Analysis!916 adding to exclusions

With the introduction of new run3 decay finder, all of the tests pass except these three:

• DaVinciExamples.tupling.test_davinci_tupling_array_taggers (Failed)
• DaVinciExamples.tupling.test_example-tupling-basic-run-mc (Failed)
• DaVinciTests.davinci.test_davinci_funtuple_array (Failed)

The ROOT files are made correctly but the validator is now catching a new warning that is being thrown. The new warnings are:

WARNING: found factory loki_functor_3493811357, but of wrong type:  instead of LoKi::Functor<LHCb::ProtoParticle const*, bool>* (*)(LoKi::Context&&)
WARNING: found factory loki_functor_3361120277, but of wrong type:  instead of LoKi::Functor<LHCb::Event::v1::Track const*, bool>* (*)(LoKi::Context&&)

These warnings are just out of the blue since I am not even using LoKi. I am not really sure of their source. I have seen them sometimes building Moore, perhaps they are harmless?

This MR includes these warnings in DV exclusions.

To tested with: Rec!3091 (merged) and Analysis!916 (merged)

requested review from @pkoppenb and @erodrigu

assigned to @amathad

changed title from Follow-up MR from https://gitlab.cern.ch/lhcb/Analysis/-/merge_requests/916#note_5967273 adding to exclusions. to Follow-up MR from Analysis!916 (merged) adding to exclusions

added DPA-WP3 Tuples labels

mentioned in merge request Analysis!916 (merged)

mentioned in merge request Rec!3091 (merged)

I will try to ask in the Core Software mattermost channel if someone has encountered this error.

I have asked it on mattermost.

assigned to @sabarre

changed the description

Sounds good. We can always revise exclusions ...

approved this merge request

• [2022-09-02 13:43] Validation started with lhcb-master-mr#5564
• [2022-09-02 17:12] Validation started with lhcb-master-mr#5565

approved this merge request

added WIP dependency label

can something like this documenation find its way into the DaVinci docs?

This comment seems a bit out of context for this specific MR but is very relevant to the work being prepared on decay finders, which should be documented.

For the moment, as a kind of placeholder, I guess one could add a little page "Decay finders" or alike under the section "user guide" at https://lhcb-davinci.docs.cern.ch/. The new work related to this MR is too early to be documented but the addition of a trivial subsection in the page on LoKi based decay finders, linking to the Twiki you mention, seems important indeed. (I say a link because we have no clock cycles at this point to go and translate the whole Twiki page into RST for the DaVinci docs site - if you can help, or anyone, that is great, as the core developers are already stretched IMO.

(@amathad, if you prefer ping me with an issue and I will take care of this page during the week ...)

I think the LoKi decay finder is still very relevant for MC decay and for reconstructed decay since we are aligning Run1 and Run3 the Grammer of decay descriptor is still relevant.

added 9 commits

• 9ab2f3d4...e58766a0 - 8 commits from branch master
• fdd0881b - Merge branch

Compare with previous version

added 5 commits

• fdd0881b...c8c83414 - 4 commits from branch master
• 9e80f816 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/lhcb/DaVinci into AM_DecayFinder

Compare with previous version

It seems this is not a problem and CI test here comes out green without adding exclusion to DV. So closing this MR.

closed

mentioned in issue Moore#478 (closed)