Skip to content
Snippets Groups Projects

Place Moore RecSummary in a stream-dependent location

Merged Alex Pearce requested to merge apearce-tesla-recsummary into master

Tesla currently writes the RecSummary at /Event/Rec/Summary, but this is a problem for TurCal productions because the input files to Tesla already have a Rec/Summary from Brunel. This MR configures stream-specific RecSummary writers to place the summary in /Event/<stream>/Turbo/Rec/Summary.

The problem is that there is already logic for linking the summary from /Event to /Event/<stream>, but for this MR to be transparent to the user we might need a link going the other way.

/cc @rmatev @sstahl

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sascha Stahl resolved all discussions

    resolved all discussions

  • Sascha Stahl resolved all discussions

    resolved all discussions

  • Alex Pearce added 1 commit

    added 1 commit

    • f2ca8648 - Configure per-stream RecSummary decoder.

    Compare with previous version

  • Edited by Software for LHCb
  • Alex Pearce added 1 commit

    added 1 commit

    • e550e8ec - Configure per-stream RecSummary decoder.

    Compare with previous version

  • Author Maintainer

    I don't know if the validation is triggered by hand, but if so: I just force-pushed to fix a configuration problem.

  • In this case yes, it was started by hand. Normally they start at midnight. Anyhow, this slot is not really relevant for this change.

  • Author Maintainer

    I ran Tesla and DaVinci with this change and TupleToolRecoStats picks up the new location without any configuration. So now I'm happy with this :ship:

  • @erodrigu are you happy to merge this? We need to then cherry-pick it into v42r5-release

  • assigned to @erodrigu

  • Sure. DaVinci is actually failing to build but the issue is not related to this MR. Thanks for pinging me.

  • mentioned in commit 21bcbae7

  • The (tesla functor cache) build is failing because the DEV version of TurboStreamProd is not up to date (/afs/cern.ch/lhcb/software/DEV/nightlies/DBASE/TurboStreamProd/v99r99).

    @bcouturi @clemenci can we have the same for TurboStreamProd as we do for AppConfig?

  • Rosen Matev mentioned in merge request !80 (merged)

    mentioned in merge request !80 (merged)

  • mentioned in commit 8a27ce09

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading