prefer ThOr over LoKi for decreport filter

added 1 commit

• ae8f4e9a - prefer ThOr over LoKi for decreport filter

Compare with previous version

added 1 commit

• 75e6dde1 - prefer ThOr over LoKi for decreport filter

Compare with previous version

added 1 commit

• 6f53ab93 - prefer ThOr over LoKi for decreport filter

Compare with previous version

/ci-test

added ci-test-triggered label

• [2023-04-11 19:32] Validation started with lhcb-master-mr#7585
• [2023-04-11 22:26] Validation started with lhcb-master-mr#7586

added 1 commit

• 6b264f41 - prefer ThOr over LoKi for decreport filter

Compare with previous version

added 1 commit

• 5aac3ca2 - convert more code to create_lines_filter instead of add_filter

Compare with previous version

added 1 commit

• 863c04d7 - convert more code to create_lines_filter instead of add_filter

Compare with previous version

added 1 commit

• a931b0cc - convert more code to create_lines_filter instead of add_filter

Compare with previous version

added 1 commit

• f835c984 - convert more code to create_lines_filter instead of add_filter

Compare with previous version

added 1 commit

• 2f9b7c7e - convert more code to create_lines_filter instead of add_filter

Compare with previous version

added ThOr label

added Configuration label

approved this merge request

Ready for a new ci-test?

added 1 commit

• a2e3279a - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 4 commits

• a2e3279a...d0163bf2 - 2 commits from branch master
• 87002c40 - prefer ThOr over LoKi for decreport filter
• 779ce995 - convert more code to create_lines_filter instead of add_filter

Compare with previous version

added 1 commit

• d6ba0153 - convert more code to create_lines_filter instead of add_filter

Compare with previous version

added 2 commits

• 9f421a96 - prefer ThOr over LoKi for decreport filter
• 4e103628 - convert more code to create_lines_filter instead of add_filter

Compare with previous version

added 1 commit

• 15662cdf - add some missing filters

Compare with previous version

requested review from @erodrigu and @pkoppenb

added 1 commit

• 5071f060 - Apply 6 suggestion(s) to 5 file(s)

Compare with previous version

added 1 commit

• c4106eab - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 4 commits

• 1b1a41bd - prefer ThOr over LoKi for decreport filter
• de40176c - convert more code to create_lines_filter instead of add_filter
• 8040fdf2 - add some missing filters
• c8cdf204 - Apply 6 suggestion(s) to 6 file(s)

Compare with previous version

added 2 commits

• e00ae013 - add some missing filters
• 9844e930 - Apply 6 suggestion(s) to 6 file(s)

Compare with previous version

added 2 commits

• 74b4210a - add some missing filters
• 445353b1 - Apply 6 suggestion(s) to 6 file(s)

Compare with previous version

added 1 commit

• 973d15f6 - Apply 4 suggestion(s) to 4 file(s)

Compare with previous version

For a separate MR: there is still one case where add_filter is used to create a LoKi_HDRFilter, and that is because it is currently possible to specify eg HLT_PASS('SomeLine') in the yaml file (using the evt_pre_filters field), which is then used to call add_filter. This type of functionality cannot be implemented 'as is' using ThOr (i.e. using create_lines_filter), as the yaml field implies plain strings and not python objects imported from Functors.

Probably the best migration path is to add a distinct field in the yaml file which just lists the required lines (as text), and use that as argument to create_lines_filter (after splitting the string into a list of lines), and at the same time flag the use to the current evt_pre_filters (which explicitly hardwires the use of LoKi already in the yaml file) as deprecated -- but this is left for a separate task.

• [2023-04-14 14:20] Validation started with lhcb-master-mr#7607

added 4 commits

• 04b5a58d - prefer ThOr over LoKi for decreport filter
• a59bccac - convert more code to create_lines_filter instead of add_filter
• 6bd8397c - add some missing filters
• 48c97e62 - Apply 4 suggestion(s) to 4 file(s)

Compare with previous version

mentioned in issue #115 (closed)

added needs ref update label

approved this merge request

The RefBot pipeline failed!

added 1 commit

• a8fac7e0 - Apply 3 suggestion(s) to 1 file(s)

Compare with previous version