Skip to content
Snippets Groups Projects

Config changes: options.stream -> options.input_stream, Turbo -> TurboPass

Merged Nicole Skidmore requested to merge lumicounting into master
All threads resolved!

Changes

  • input_process with type InputProcessTypes has been promoted to Moore level
  • 'stream'->'input_stream'
  • InputProcessTypes 'Turbo' -> 'TurboPass' so the stream and the process are not mixed up

For

LHCb!4064 (merged)

and

Moore!2153 (merged)

Edited by Nicole Skidmore

Merge request reports

Merge request pipeline #5439003 passed

Merge request pipeline passed for eed375d8

Approval is optional

Merged by Patrick KoppenburgPatrick Koppenburg 2 years ago (Apr 19, 2023 7:54am UTC)

Pipeline #5445460 passed

Pipeline passed for b52cd3fa on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Eduardo Rodrigues requested review from @pkoppenb

    requested review from @pkoppenb

  • Hey @nskidmor, thank you for this update that is related to work on FSRs. I left a few trivial comments and some less trivial. I think we need to carefully rediscuss the usage of stream/input_stream for the future, to avoid too many (design) changes later in the year ... Indeed this is now getting a bit messy, I feel, and we should not forget that next year we will have other streams defined, not only the 3 dealt with here. We need to get the code ready to be able to deal with "PhysStreamCharm", "PhysStreamQEE", etc., where the names are simple placeholder examples for the several physics streams we will get out of Sprucing jobs.

    Edited by Eduardo Rodrigues
  • Nicole Skidmore added 7 commits

    added 7 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Nicole Skidmore changed the description

    changed the description

  • added 1 commit

    Compare with previous version

  • Nicole Skidmore resolved all threads

    resolved all threads

  • Nicole Skidmore requested review from @cburr

    requested review from @cburr

  • Nicole Skidmore mentioned in merge request Moore!2153 (merged)

    mentioned in merge request Moore!2153 (merged)

  • Edited by Software for LHCb
  • added 1 commit

    Compare with previous version

  • Nicole Skidmore requested review from @erodrigu

    requested review from @erodrigu

  • Patrick Koppenburg approved this merge request

    approved this merge request

  • mentioned in commit b52cd3fa

  • Eduardo Rodrigues resolved all threads

    resolved all threads

  • Jamie Gooding mentioned in merge request Moore!1979 (merged)

    mentioned in merge request Moore!1979 (merged)

  • removed enhancement label

  • added cleanup label

  • Please register or sign in to reply
    Loading