Draft: Fixed AlignmentUseCase when changing ROOT Unit

Changed the DetectorDataService as a "* 10 " had been introduced to convert the units. Not only it should not have been done this way, but I also be;lieve that the DetectorDataService should not play with units itself. @clemenci @jonrob what do you think ?

marked this merge request as draft

added dd4hep lhcb-dd4hep labels

added 1 commit

• d693e1f0 - Added needed conversion as yaml_converters expect data in G4 units

Compare with previous version

• [2022-06-28 00:04] Validation started with lhcb-dd4hep-g4units#6
• [2022-06-28 00:04] Validation started with lhcb-dd4hep#1184
• [2022-06-28 09:46] Validation started with lhcb-dd4hep#1185
• [2022-06-29 00:04] Validation started with lhcb-dd4hep-g4units#7
• [2022-06-29 00:05] Validation started with lhcb-dd4hep#1186
• [2022-06-29 09:54] Validation started with lhcb-dd4hep#1187

mentioned in merge request !227 (merged)

added 1 commit

• 5e62692a - Clean up Units.h

Compare with previous version

resolved all threads

I cleaned up a bit Units.h and synchronized it with the version in !227 (merged) to avoid conflicts

@bcouturi There's a trivial build warning to fix. See

https://lhcb-nightlies.web.cern.ch/nightly/lhcb-dd4hep/1187/Detector/x86_64_v2-centos7-gcc11%2Bdd4hep-opt/build

I can take care of it once I finish I counter proposal I'm preparing.

Since !231 (merged) actually supersedes this change, I want to try to use that MR instead of this one in lhcb-dd4hep.

mentioned in merge request !231 (merged)

removed lhcb-dd4hep label

mentioned in merge request !232 (closed)

Superseeded by !231 (merged)

closed