Change MUON readout definition

Change needed to run G-on-G with the muon system using DD4HEP

requested review from @mimazure

assigned to @sponce and @bcouturi

I actually spotted a problem with the Muon <readout> definitions yesterday when running:

geoPluginRun -input compact/trunk/LHCb.xml -plugin DD4hep_VolumeManager -plugin DD4hep_DetectorDump -positions

to dump the VP sensor positions.

I was going to create an issue for this but no need now. There is a similar problem in the FT but I can raise that separately.

Can you check that running:

geoPluginRun -input compact/trunk/debug/Muon_debug.xml -plugin DD4hep_VolumeManager -plugin DD4hep_DetectorDump

works ok with this MR? IIRC there are lots of <readout> entries defined in the Muon and only one of them is changed here.

Running ./InstallArea/x86_64_v2-centos7-gcc11+dd4hep-opt/bin/run geoPluginRun -input compact/trunk/debug/Muon_debug.xml -plugin DD4hep_VolumeManager -plugin DD4hep_DetectorDump I get Instead running gaussino works fine for the geometry and I get errors at Hit level

Adding to lhcb-gaussino slot.

Note: this will not yet be activated in the tests as there is one more thing to do on the G-on-G side.

See: Gauss!872 (merged) and Gauss!850 (comment 5785992)

added Muon lhcb-gaussino labels

• [2022-07-28 01:59] Validation started with lhcb-gaussino#1280
• [2022-07-28 02:07] Validation started with lhcb-gaussino-new-cmake#216
• [2022-07-29 00:22] Validation started with lhcb-gaussino-new-cmake#217
• [2022-07-29 00:23] Validation started with lhcb-gaussino#1281
• [2022-07-30 00:07] Validation started with lhcb-gaussino-new-cmake#218
• [2022-07-30 00:07] Validation started with lhcb-gaussino#1282
• [2022-07-31 00:03] Validation started with lhcb-gaussino-new-cmake#219
• [2022-07-31 00:03] Validation started with lhcb-gaussino#1283
• [2022-08-02 00:11] Validation started with lhcb-gaussino-new-cmake#220
• [2022-08-02 00:12] Validation started with lhcb-gaussino#1284
• [2022-08-03 00:04] Validation started with lhcb-gaussino-new-cmake#221
• [2022-08-03 00:04] Validation started with lhcb-gaussino#1285
• [2022-08-04 00:04] Validation started with lhcb-gaussino-new-cmake#222
• [2022-08-04 00:04] Validation started with lhcb-gaussino#1286
• [2022-08-05 00:03] Validation started with lhcb-gaussino-new-cmake#223
• [2022-08-05 00:03] Validation started with lhcb-gaussino#1287
• [2022-08-06 00:04] Validation started with lhcb-gaussino-new-cmake#224
• [2022-08-06 00:04] Validation started with lhcb-gaussino#1288
• [2022-08-10 00:11] Validation started with lhcb-gaussino-new-cmake#225
• [2022-08-10 00:12] Validation started with lhcb-gaussino#1289
• [2022-08-11 00:03] Validation started with lhcb-gaussino-new-cmake#226
• [2022-08-11 00:04] Validation started with lhcb-gaussino#1290
• [2022-08-12 00:10] Validation started with lhcb-gaussino-new-cmake#227
• [2022-08-12 00:12] Validation started with lhcb-gaussino#1291
• [2022-08-13 00:06] Validation started with lhcb-gaussino-new-cmake#228
• [2022-08-13 00:06] Validation started with lhcb-gaussino#1292
• [2022-08-16 00:04] Validation started with lhcb-gaussino-new-cmake#229
• [2022-08-16 00:04] Validation started with lhcb-gaussino#1293
• [2022-08-17 00:10] Validation started with lhcb-gaussino-new-cmake#230
• [2022-08-17 00:11] Validation started with lhcb-gaussino#1294
• [2022-08-18 00:13] Validation started with lhcb-gaussino-new-cmake#231
• [2022-08-18 00:13] Validation started with lhcb-gaussino#1295
• [2022-08-19 00:03] Validation started with lhcb-gaussino#1296
• [2022-08-19 13:50] Validation started with lhcb-gaussino#1297
• [2022-08-19 14:30] Validation started with lhcb-gaussino#1298
• [2022-08-20 00:05] Validation started with lhcb-gaussino-new-cmake#233
• [2022-08-20 00:05] Validation started with lhcb-gaussino#1299
• [2022-08-21 00:09] Validation started with lhcb-gaussino-new-cmake#234
• [2022-08-21 00:11] Validation started with lhcb-gaussino#1300
• [2022-08-23 00:05] Validation started with lhcb-gaussino-new-cmake#235
• [2022-08-23 00:05] Validation started with lhcb-gaussino#1301
• [2022-08-24 00:10] Validation started with lhcb-gaussino-new-cmake#236
• [2022-08-24 00:11] Validation started with lhcb-gaussino#1302
• [2022-08-25 00:06] Validation started with lhcb-gaussino-new-cmake#237
• [2022-08-25 00:07] Validation started with lhcb-gaussino#1303
• [2022-08-26 00:06] Validation started with lhcb-gaussino-new-cmake#238
• [2022-08-26 00:07] Validation started with lhcb-gaussino#1304
• [2022-08-27 00:04] Validation started with lhcb-gaussino-new-cmake#239
• [2022-08-27 00:05] Validation started with lhcb-gaussino#1305
• [2022-08-28 00:03] Validation started with lhcb-gaussino-new-cmake#240
• [2022-08-28 00:03] Validation started with lhcb-gaussino#1306
• [2022-08-29 00:03] Validation started with lhcb-gaussino-new-cmake#241
• [2022-08-29 00:03] Validation started with lhcb-gaussino#1307
• [2022-08-30 00:05] Validation started with lhcb-gaussino-new-cmake#242
• [2022-08-30 00:05] Validation started with lhcb-gaussino#1308
• [2022-08-30 11:54] Validation started with lhcb-gaussino-new-cmake#243
• [2022-08-30 14:12] Validation started with lhcb-gaussino-new-cmake#244
• [2022-08-30 14:52] Validation started with lhcb-gaussino-new-cmake#245
• [2022-08-31 00:08] Validation started with lhcb-gaussino-new-cmake#246
• [2022-08-31 00:11] Validation started with lhcb-gaussino#1309
• [2022-09-01 00:05] Validation started with lhcb-gaussino-new-cmake#247
• [2022-09-01 00:07] Validation started with lhcb-gaussino#1310
• [2022-09-02 00:03] Validation started with lhcb-gaussino-new-cmake#248
• [2022-09-02 00:03] Validation started with lhcb-gaussino#1311
• [2022-09-03 00:08] Validation started with lhcb-gaussino-new-cmake#249
• [2022-09-03 00:10] Validation started with lhcb-gaussino#1312
• [2022-09-04 00:25] Validation started with lhcb-gaussino-new-cmake#250
• [2022-09-04 00:25] Validation started with lhcb-gaussino#1313
• [2022-09-07 00:10] Validation started with lhcb-gaussino-new-cmake#251
• [2022-09-07 00:18] Validation started with lhcb-gaussino#1314
• [2022-09-08 00:11] Validation started with lhcb-gaussino#1315
• [2022-09-08 00:12] Validation started with lhcb-gaussino-new-cmake#252
• [2022-09-09 00:09] Validation started with lhcb-gaussino-new-cmake#253
• [2022-09-09 00:09] Validation started with lhcb-gaussino#1316
• [2022-09-10 00:25] Validation started with lhcb-gaussino-new-cmake#254
• [2022-09-10 00:28] Validation started with lhcb-gaussino#1317
• [2022-09-13 00:08] Validation started with lhcb-gaussino-new-cmake#255
• [2022-09-13 00:10] Validation started with lhcb-gaussino#1318
• [2022-09-14 00:04] Validation started with lhcb-gaussino-new-cmake#256
• [2022-09-14 00:04] Validation started with lhcb-gaussino#1319
• [2022-09-15 00:04] Validation started with lhcb-gaussino-new-cmake#257
• [2022-09-15 00:06] Validation started with lhcb-gaussino#1320
• [2022-09-16 00:03] Validation started with lhcb-gaussino-new-cmake#258
• [2022-09-16 00:03] Validation started with lhcb-gaussino#1321
• [2022-09-17 00:03] Validation started with lhcb-gaussino-new-cmake#259
• [2022-09-17 00:05] Validation started with lhcb-gaussino#1322
• [2022-09-19 00:03] Validation started with lhcb-gaussino-new-cmake#260
• [2022-09-19 00:03] Validation started with lhcb-gaussino#1323
• [2022-09-19 16:04] Validation started with lhcb-gaussino-new-cmake#261
• [2022-09-19 16:45] Validation started with lhcb-gaussino-new-cmake#262
• [2022-09-20 00:06] Validation started with lhcb-gaussino-new-cmake#263
• [2022-09-20 00:08] Validation started with lhcb-gaussino#1324
• [2022-09-21 00:04] Validation started with lhcb-gaussino-new-cmake#264
• [2022-09-21 00:04] Validation started with lhcb-gaussino#1325
• [2022-09-22 00:08] Validation started with lhcb-gaussino-new-cmake#265
• [2022-09-22 00:11] Validation started with lhcb-gaussino#1326
• [2022-09-22 13:44] Validation started with lhcb-gaussino-new-cmake#266
• [2022-09-22 15:00] Validation started with lhcb-gaussino-new-cmake#267
• [2022-09-23 00:05] Validation started with lhcb-gaussino#1327
• [2022-09-24 00:07] Validation started with lhcb-gaussino#1328
• [2022-09-27 00:05] Validation started with lhcb-gaussino#1329
• [2022-09-28 00:11] Validation started with lhcb-gaussino#1330
• [2022-09-29 00:06] Validation started with lhcb-gaussino#1331
• [2022-10-01 00:04] Validation started with lhcb-gaussino#1332
• [2022-10-04 00:05] Validation started with lhcb-gaussino#1333
• [2022-10-05 00:05] Automatic merge failed in [lhcb-gaussino#1334](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1334/Detector/checkout
• [2022-10-06 00:08] Automatic merge failed in [lhcb-gaussino#1335](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1335/Detector/checkout
• [2022-10-07 00:08] Automatic merge failed in [lhcb-gaussino#1336](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1336/Detector/checkout
• [2022-10-08 00:09] Automatic merge failed in [lhcb-gaussino#1337](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1337/Detector/checkout
• [2022-10-11 00:04] Automatic merge failed in [lhcb-gaussino#1338](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1338/Detector/checkout
• [2022-10-11 11:26] Automatic merge failed in [lhcb-gaussino#1339](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1339/Detector/checkout
• [2022-10-11 11:52] Automatic merge failed in [lhcb-gaussino#1340](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1340/Detector/checkout
• [2022-10-12 00:08] Automatic merge failed in [lhcb-gaussino#1341](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1341/Detector/checkout
• [2022-10-13 00:13] Automatic merge failed in [lhcb-gaussino#1342](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1342/Detector/checkout
• [2022-10-14 00:03] Automatic merge failed in [lhcb-gaussino#1343](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1343/Detector/checkout
• [2022-10-15 00:12] Automatic merge failed in [lhcb-gaussino#1344](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1344/Detector/checkout
• [2022-10-18 00:04] Automatic merge failed in [lhcb-gaussino#1345](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1345/Detector/checkout
• [2022-10-19 00:03] Automatic merge failed in [lhcb-gaussino#1346](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1346/Detector/checkout
• [2022-10-20 00:08] Automatic merge failed in [lhcb-gaussino#1347](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1347/Detector/checkout
• [2022-10-21 00:04] Automatic merge failed in [lhcb-gaussino#1348](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1348/Detector/checkout
• [2022-10-22 00:03] Automatic merge failed in [lhcb-gaussino#1349](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1349/Detector/checkout
• [2022-10-25 00:03] Automatic merge failed in [lhcb-gaussino#1350](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1350/Detector/checkout
• [2022-10-26 00:03] Automatic merge failed in [lhcb-gaussino#1351](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1351/Detector/checkout
• [2022-10-27 00:08] Automatic merge failed in [lhcb-gaussino#1352](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1352/Detector/checkout
• [2022-10-28 00:08] Automatic merge failed in [lhcb-gaussino#1353](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1353/Detector/checkout
• [2022-10-29 00:04] Automatic merge failed in [lhcb-gaussino#1354](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1354/Detector/checkout
• [2022-11-01 00:03] Automatic merge failed in [lhcb-gaussino#1355](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1355/Detector/checkout
• [2022-11-02 00:03] Automatic merge failed in [lhcb-gaussino#1356](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1356/Detector/checkout
• [2022-11-02 14:17] Automatic merge failed in [lhcb-gaussino#1357](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1357/Detector/checkout
• [2022-11-02 14:28] Automatic merge failed in [lhcb-gaussino#1358](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1358/Detector/checkout
• [2022-11-02 14:48] Automatic merge failed in [lhcb-gaussino#1359](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1359/Detector/checkout
• [2022-11-03 00:08] Automatic merge failed in [lhcb-gaussino#1360](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1360/Detector/checkout
• [2022-11-04 00:03] Automatic merge failed in [lhcb-gaussino#1361](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1361/Detector/checkout
• [2022-11-04 14:15] Automatic merge failed in [lhcb-gaussino#1362](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1362/Detector/checkout
• [2022-11-05 00:11] Automatic merge failed in [lhcb-gaussino#1363](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1363/Detector/checkout
• [2022-11-07 11:54] Automatic merge failed in [lhcb-gaussino#1364](https://lhcb-nightlies.web.cern.ch/nightly/lhcb-gaussino/1364/Detector/checkout

changed title from Change readout Region definition: adding Station and Side to Change MUON readout Region definition: adding Station and Side

I've had a good look at this and I must admit I'm very confused by how the readout stuff is done for the Muon. I think it's actually incorrect. I have put together a version that I believe works correctly. Do you want me to push it to this branch or shall I push it into a separate one?

mentioned in merge request LHCb!3727 (closed)

added 2 commits

• f52a5b43 - Fix readout issues for Muon
• 853e6667 - Merge branch 'tlatham_muon_readout_fix' into 'edelucia-muon-detector-dd4hep'

Compare with previous version

resolved all threads

added 150 commits

• 853e6667...2d71399a - 149 commits from branch master
• 9e9283aa - Merge remote-tracking branch 'origin/master' into edelucia-muon-detector-dd4hep

Compare with previous version

changed title from Change MUON readout Region definition: adding Station and Side to Change MUON readout definition

This MR is out of sync with master. Can we also test this in lhcb-dd4hep?

That will not help, the conflicts will anyway need merging there as well.

So bottom line is the merge conflicts must to addressed before this can be tested.

@edelucia @desimone what is the status of this MR? I'm removing the lhcb-gaussino label for now as it is not picked up anyway due to conflicts. FYI @gcorti

These changes are not in Detector so we should figure out the easiest and fastest way to do it also with @desimone.

as @jonrob says, first we need a rebase.

ping

@edelucia To make progress here you need to rebase the branch used, and fix the conflicts with master. Can you please look into this ?

Yes, I am looking into this. Thank you

With @desimone decided to restart from latest version of Detector in master and add the fix there.

removed review request for @mimazure

removed lhcb-gaussino label

@edelucia Any changes you make to compact/trunk also, for now, need to be cloned in the compact/before-rich1-geom-update-26052022 area. can you do this please ?

Yes, I will

mentioned in merge request !318 (merged)