Fixed Muon DD4hep VolumeID and added decoding class

Fixed the DD4hep VolumeID in the Detector description and added the MuonVolumeID decoding class that returns the same values as the DeMuon sensitiveVolumeID()

assigned to @farchill

added 1 commit

• de3902fe - Changed region IDs

Compare with previous version

added 1 commit

• 90a638c4 - Added readout ID in XML

Compare with previous version

added 1 commit

• 4b672fa7 - Backported readout to before-rich1-geom-update-26052022

Compare with previous version

added 1 commit

• 9316a417 - Added readout ID in XML

Compare with previous version

I added a test that compares the values we get by decoding the DD4hep volumeID to the output of sensitiveVolumeID() implemented in DeMuon. The results are exported in a CSV file (see first result attached).

detelements.csv

At the current stage, we have:

• there are more than 1000 cases (over 4415) where passing the (x,y,z) point of the GasGapLayer in DD4hep to sensitiveVolumeID returned -1. Not sure what is happening in this case, maybe I have the wrong position.
• In the 3312 other cases, stationID/regionID/ChamberID all match
• we have a difference in the GapIDs, they are all different
• QuandrantID is not implemented

added 1 commit

• cbe90f49 - Fixed GasGap issues and comparison of DD4hep ID

Compare with previous version

Previous commit fixes the mismatch in gasGap (the problem was a bad index in sensitiveVolumeID that @svecchi pointed out. many thanks!) Now the stationID, RegionID, ChamberID all match.

Remaineing issue is how to derive the quadrantID

added 1 commit

• 4bcc8969 - Added code to derive quadrantID

Compare with previous version

The code to derive the quadrantID has been added to the test only. It just needs to be added to DeMuon and this should be complete, I will follow the naming convention started in the VP.

added 1 commit

• 2b97e9b2 - Added MuonVolumeID class

Compare with previous version

I added the MuonVolumeID class that allows decoding the ID returned by DD4hep.

added 1 commit

• 4611f8fd - Added readout ID in XML and a class to decode the DD4hep Muon VolumeID and asociated test

Compare with previous version

marked this merge request as ready

changed title from Added readout ID in XML to Fixed DD4hep VolumeID and added decoding class

changed the description

added 8 commits

• 4611f8fd...42bba0b8 - 7 commits from branch master
• 52df94b8 - Added readout ID in XML and a class to decode the DD4hep Muon VolumeID and asociated test

Compare with previous version

assigned to @sponce

changed title from Fixed DD4hep VolumeID and added decoding class to Fixed Muon DD4hep VolumeID and added decoding class

added 1 commit

• f0e9e2c8 - Added readout ID in XML and a class to decode the DD4hep Muon VolumeID and associated test

Compare with previous version