Skip to content
Snippets Groups Projects

Draft: Updating RICH with Rich1 mirror survey updates in January16-2024

Closed Sajan Easo requested to merge Rich1-MirrorSurvey-Updates-January-2024 into master

This contains the Rich1 Mirror survey updates for 2023 data, which may potentially improve the resolutions seen in RICH1 in 2023. This branch is created wrt the master version on Jan16-2024. The updates for the survey parameters are created in the trunk area. This will need the references updated and the new alignment parameters created in the conditions database, before making any tests.

A second issue is that, the RICH group would like to continue to use the current version also, since the Rich1 alignments are created wrt this version in 2023. For this, following earlier discussions last year, I created a new folder named Rich_RUN3_v1_01092023 which has the 'current master version' so that it can be kept frozen. However there is difficulty in commiting this since it fails the check_path_xml.py although I tried to update this also. It seems, this script works OK when it is run directly, but not when it is part of pre-commit checks. As a temporary measure I deactivated the path.xml in this area until this issue is fixed.


Validated by

  • Core Software
  • RTA
  • Simulation
Edited by Marco Clemencic

Merge request reports

Merge request pipeline #9910603 passed with warnings

Merge request pipeline passed with warnings for 098b3713

Approval is optional

Closed by Miroslav SaurMiroslav Saur 2 months ago (Feb 4, 2025 8:51am UTC)

Merge details

  • The changes were not merged into .

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • assigned to @sponce and @bcouturi

  • Sajan Easo added 1 commit

    added 1 commit

    • 37b3c1b7 - Update path.xml in Rich_RUN3_v1_01092023/debug area

    Compare with previous version

  • Sajan Easo added 105 commits

    added 105 commits

    • 37b3c1b7...56923fa2 - 99 commits from branch master
    • c79eda43 - Updating with Rich1 mirror survey parameters for RUN3
    • 51fb1f22 - Creating a frozen version of Rich in RUN3 corresponding to alignments created in 2023
    • cb4b207d - Update path.xml in Rich_RUN3_v1_01092023/debug area
    • 8f4b40a7 - Rich1 mirror survery updates for 2024 Run
    • 7d911c17 - Rich2 : Overalap fixes
    • 75df70db - Checksum updates April2024

    Compare with previous version

  • Author Developer

    This is now rebased with the master as of April 15-2024.

    A minor set of overlaps in RICH2 is also fixed in this MR. At present the ../compact/run3/trunk area is made same as ../compact/run3/2024.Q1.2-v00.00 area.

    Two things to be done:

    (a)

    mv ../compact/run3/Rich_RUN3_v1_01092023/path-xml ../compact/run3/Rich_RUN3_v1_01092023/path.xml

    mv ../compact/run3/2024.Q1.2-v00.00/path-xml ../compact/run3/2024.Q1.2-v00.00/path.xml

    In order to make the 'git commit' work in my area, the path.xml was renamed to path-xml in the above mentioned areas as a temporary measure. This essentially may need a fix in the script ../scripts/check_path_xml.py before the path-xml can be renamed back to path.xml

    (b) The lhcb-conditions-database to be updated with the corresponding Rich1 mirror alignment parameters. The alignment group is aware of this, for this MR

    Edited by Sajan Easo
  • Sajan Easo marked this merge request as ready

    marked this merge request as ready

  • Gloria Corti assigned to @mexu and unassigned @sponce

    assigned to @mexu and unassigned @sponce

  • Alex Marshall added 9 commits

    added 9 commits

    • a0fa2119 - Merge branch 'protect-against-missing-0-cond' into 'master'
    • dc4036cf - Merge branch 'cherry-pick-b644fdee' into '2024-patches'
    • 961aa3e4 - cherry-pick the changes in checksum at master branch
    • 8182d672 - Merge branch 'cherry-pick-56923fa2-2' into '2024-patches'
    • 7f8929a8 - Access to LHC condition information
    • 7b8a2155 - Merge branch 'tfulghes-lhc-conditions' into '2024-patches'
    • e2acad9b - Prepare Detector v1r31
    • f68a422f - Merge branch 'release-v1r31' into '2024-patches'
    • 25c07697 - merge up

    Compare with previous version

  • Marco Clemencic added 12 commits

    added 12 commits

    • 25c07697...88923dc5 - 2 commits from branch master
    • 9dc8cde4 - Make VP A and C side more explicit with an enum struct
    • 5826d9fa - Merge branch 'tmombach_fixACside' into '2024-patches'
    • d4d360ff - Read SMOG condition from DeLHCb
    • 89e22dec - Merge branch 'samarian_read_smog_condition' into '2024-patches'
    • fe1090a8 - Updating with Rich1 mirror survey parameters for RUN3
    • 5bd86ad4 - Creating a frozen version of Rich in RUN3 corresponding to alignments created in 2023
    • 358dcc35 - Update path.xml in Rich_RUN3_v1_01092023/debug area
    • 38055a55 - Rich1 mirror survery updates for 2024 Run
    • 01f90984 - Rich2 : Overalap fixes
    • e3e8a13b - Checksum updates April2024

    Compare with previous version

  • Marco Clemencic changed target branch from master to 2024-patches

    changed target branch from master to 2024-patches

  • added 4 commits

    • f2a4928b - Updating with Rich1 mirror survey parameters for RUN3
    • ef2d58fa - Rich2 : Overalap fixes
    • b691065e - Create geometry version 2024.Q1.2-v01.00 with 2024 Rich mirrors survey
    • 288c1660 - Update trunk checksums

    Compare with previous version

  • Marco Clemencic marked the checklist item Core Software as completed

    marked the checklist item Core Software as completed

  • @seaso and I updated the MR to apply Rich1 survey and fix Rich2 overlaps in run3/trunk, then we created a new tag to be selected setting geometry_version = "2024-v01.00".

    @rmatev, how can we get this new version of the geometry used by Hlt and alignments?

  • Marco Clemencic resolved all threads

    resolved all threads

  • Marco Clemencic changed title from Upating RICH with Rich1 mirror survey updates in January16-2024 to Updating RICH with Rich1 mirror survey updates in January16-2024

    changed title from Upating RICH with Rich1 mirror survey updates in January16-2024 to Updating RICH with Rich1 mirror survey updates in January16-2024

  • Sajan Easo resolved all threads

    resolved all threads

  • Author Developer

    Dear @rmatev , @jonrob et.al. This may be obvious but thought I mention anyway. For this MR, some of the standard tests included in the usual (ci ) test may need the new ‘Rich alignment parameters’ from the lhcb-conditions-database, for them to be successful. In this context, if it is best to ignore those tests or one needs to have these parameters available in some branch of the DB beforehand, please let us know. One may also note that this update is in a new geometry version (..v01..) compared to the current online version (..v00..) and hence is somewhat decoupled to what happens in online these days, for now.

  • Sajan Easo mentioned in merge request !553

    mentioned in merge request !553

  • Sajan Easo added 37 commits

    added 37 commits

    • 288c1660...b041737d - 2 commits from branch 2024-patches
    • b041737d...e94f7b6b - 25 earlier commits
    • 717925f7 - Merge remote-tracking branch 'origin/master' into 2024-patches-sync
    • bf1ed684 - Merge branch '2024-patches-sync' into 'master'
    • 98851a58 - Change FT geometry for MP
    • 0a0cafd3 - Merge branch 'MP-changeFT-assembly' into 'master'
    • 11cd2513 - move the parameters from T/parameters.xml to Regions/parameters.xml
    • ee98feff - Merge branch 'mexu_T_region' into 'master'
    • fbe829cb - Updating with Rich1 mirror survey parameters for RUN3
    • 4c1d9534 - Rich2 : Overalap fixes
    • c352e83a - Create geometry version 2024.Q1.2-v01.00 with 2024 Rich mirrors survey
    • 66235891 - Rebasing with master on May28-2024 and updating run3/trunk/checksums

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading