Add SMOG2 (again)

Opening a new MR to add SMOG2 due to several changes since !280 (closed)

works with Gauss!1101 (merged)

added dd4hep label

requested review from @samarian, @bcouturi, and @tlatham

assigned to @gcorti

Hi @bcouturi @tlatham I essentially reproduced !280 (closed) on current master for this MR, but geoDisplay now says

Compact ERROR FAILED subdetector:SMOG2_L of type LHCb_SMOG2_Left_v1_0 PluginService ERROR Factory requested: LHCb_SMOG2_Left_v1_0 (N10__cxxabiv120__function_type_infoE) :bad any_cast PluginService ERROR Stub is invalid! Compact ERROR ++ FAILED to convert subdetector: SMOG2_L: Failed to execute subdetector creation plugin. No factory with name Create(LHCb_SMOG2_Left_v1_0) for type LHCb_SMOG2_Left_v1_0 found. Please check library load path and/or plugin factory name.

with x86_64_v2-el9-gcc12-opt , do you know why?

added 1 commit

• d4aa2df2 - adding cpp to CMakeLists

Compare with previous version

resolved all threads

@bcouturi @tlatham I have a visualization bug with geoDisplay: SMOG2 should appear like in slide 12 here: https://indico.cern.ch/event/1117668/contributions/4693663/attachments/2384215/4074363/VELO-and-SMOG2-Geometry.pdf I didn't change the geometry since then. But now if I run geoDisplay some supports are invisible: I tried to change alpha/colors without success. However, If I increase their size by 10x they appear again: Is there a better way to visualize?

added 1 commit

• 42b2ed4b - fixed SMOG2-VP debug xml

Compare with previous version

added 1 commit

• aef868b5 - pre-commit fixes

Compare with previous version

added 1 commit

• 6c780be0 - removed overlapping beampipe

Compare with previous version

With @samarian @gcorti we cut the beam pipe part overlapping with SMOG2, and left a thin space shown in the figure. @bcouturi @tlatham please have a look at the commit !524 (6c780be0)

marked this merge request as ready

added backport sim10 new feature labels

The label backport sim10 is to indicate that to include this geometry in Sim10, instead of writing DDDB we will save a GMDL version with Gauss-on-Gsino and import it at run time.

To be checked what will need to be replaced as volumes in the DDDB description, as to prevent overlaps.

added 28 commits

• 6c780be0...2860732d - 21 commits from branch master
• 6329514e - adding SMOG2
• 01d4f2f5 - fixing paths
• 75b5c9ad - adding cpp to CMakeLists
• dfba3540 - fixed SMOG2-VP debug xml
• 3882e9ae - pre-commit fixes
• 552d67f7 - removed overlapping beampipe
• ae387ba5 - Fix ci test importing SMOG after VP

Compare with previous version

This morning @bcouturi and I tried to check whether the overlap was fixed, but got the following crash that I think is maybe unrelated? Maybe @tlatham can you give us a hint please?

$ python geometryvalidation/pyg4ometry-scripts/showOverlaps.py LHCb_with_SMOG2.gdml 
Traceback (most recent call last):
  File "/home/lben/develop/master/geometryvalidation/pyg4ometry-scripts/showOverlaps.py", line 24, in <module>
    r = Reader( filename )
  File "/cvmfs/lhcbdev.cern.ch/conda/envs/geometryvalidation/2022-04-07_14-53/linux-64/lib/python3.9/site-packages/pyg4ometry/gdml/Reader.py", line 21, in __init__
    self.load()
  File "/cvmfs/lhcbdev.cern.ch/conda/envs/geometryvalidation/2022-04-07_14-53/linux-64/lib/python3.9/site-packages/pyg4ometry/gdml/Reader.py", line 99, in load
    self.parseStructure(xmldoc)
  File "/cvmfs/lhcbdev.cern.ch/conda/envs/geometryvalidation/2022-04-07_14-53/linux-64/lib/python3.9/site-packages/pyg4ometry/gdml/Reader.py", line 1355, in parseStructure
    self.extractStructureNodeData(node)
  File "/cvmfs/lhcbdev.cern.ch/conda/envs/geometryvalidation/2022-04-07_14-53/linux-64/lib/python3.9/site-packages/pyg4ometry/gdml/Reader.py", line 1393, in extractStructureNodeData
    vol = _g4.LogicalVolume(self._registry.solidDict[solid], mat, name, registry=self._registry,
  File "/cvmfs/lhcbdev.cern.ch/conda/envs/geometryvalidation/2022-04-07_14-53/linux-64/lib/python3.9/site-packages/pyg4ometry/geant4/LogicalVolume.py", line 87, in __init__
    self.reMesh()
  File "/cvmfs/lhcbdev.cern.ch/conda/envs/geometryvalidation/2022-04-07_14-53/linux-64/lib/python3.9/site-packages/pyg4ometry/geant4/LogicalVolume.py", line 107, in reMesh
    self.mesh = _Mesh(self.solid)
  File "/cvmfs/lhcbdev.cern.ch/conda/envs/geometryvalidation/2022-04-07_14-53/linux-64/lib/python3.9/site-packages/pyg4ometry/visualisation/Mesh.py", line 27, in __init__
    self.localboundingmesh = self.getBoundingBoxMesh()
  File "/cvmfs/lhcbdev.cern.ch/conda/envs/geometryvalidation/2022-04-07_14-53/linux-64/lib/python3.9/site-packages/pyg4ometry/visualisation/Mesh.py", line 56, in getBoundingBoxMesh
    bb = self.getBoundingBox()
  File "/cvmfs/lhcbdev.cern.ch/conda/envs/geometryvalidation/2022-04-07_14-53/linux-64/lib/python3.9/site-packages/pyg4ometry/visualisation/Mesh.py", line 53, in getBoundingBox
    return _getBoundingBox(self.localmesh, rotationMatrix, translation, self.solid)
  File "/cvmfs/lhcbdev.cern.ch/conda/envs/geometryvalidation/2022-04-07_14-53/linux-64/lib/python3.9/site-packages/pyg4ometry/visualisation/Mesh.py", line 67, in _getBoundingBox
    raise pyg4ometry.exceptions.NullMeshError(nameForError)
pyg4ometry.exceptions.NullMeshError: Union PipeJuncB4VeloSteelUnion_shape_0x4cec5c0(JuncSteelCone JuncSteelCone0x1)

added 1 commit

• 1f7476f5 - Fix NullMesh problem in PipeJuncB4VeloSteelUnion

Compare with previous version