Streamline MagneticField grid reader

• Streamline magnetic field grid reader and improve error checking
• prefer std::unique_ptr over std::shared_ptr

---

Validated by

• Core Software
• RTA
• Simulation

requested review from @jonrob and @bcouturi

changed the description

added 1 commit

• 66e71603 - Streamline MagneticField handling

Compare with previous version

Seems OK, although I'll defer approval until after some ci tests have been run.

Is the aim here to speed things up at all, or is this just a 'clan up' ?

Hi @graven, I don't recall why a shared pointer was used at that stage, but indeed it doesn't seem needed any more if it was.

Was there a performance problem with the access ?

Concerning the target branch, should this go to 2024_patches or master ?

added 9 commits

• 66e71603...27eed184 - 8 commits from branch 2024-patches
• 4d8a378f - Streamline MagneticField handling

Compare with previous version

added 5 commits

• 4d8a378f...30f3e369 - 4 commits from branch 2024-patches
• 5aee616f - Streamline MagneticField handling

Compare with previous version

added 3 commits

• 5aee616f...a281db1a - 2 commits from branch 2024-patches
• 0c0200e1 - Streamline MagneticField handling

Compare with previous version

added 73 commits

• 0c0200e1...a6f9fd8c - 63 earlier commits
• 2863e268 - Merge branch '2024-patches-sync' into 'master'
• f9b65f17 - Scenario Heavy
• 3bb20ee8 - Merge branch 'TV_Sx_Heavy' into 'master'
• 5d897833 - Updated z positions for FT and MP stations
• 4b68ef10 - Merge branch 'MP_FT_updateZpositions' into 'master'
• 161bf5af - Tidying up MP parameters xml file.
• 9ee7dd31 - Merge branch 'groberts-MPparameters-cleanup' into 'master'
• 92c87417 - MP: fix volumeID
• d974c423 - Merge branch 'groberts-MP-fixVolumeID' into 'master'
• 6be26df0 - Streamline MagneticField handling

Compare with previous version

changed target branch from 2024-patches to master

ping...

mentioned in issue Moore#896 (closed)

Seems like this has been forgotten. Let's retest and merge if all is fine

\ci-test

\ci-test

resolved all threads

/ci-test

added ci-test-triggered label

• [2025-02-11 11:01] Validation started with lhcb-master-mr#12543
• [2025-02-27 15:40] Validation started with lhcb-master-mr#12722
• [2025-02-28 14:41] Validation started with lhcb-master-mr#12738
• [2025-03-04 13:12] Validation started with lhcb-sim11-mr#289
• [2025-03-28 08:58] Validation started with lhcb-master-mr#13130
• [2025-03-28 08:58] Validation started with lhcb-sim11-mr#356

added 100 commits

• 6be26df0...80c1ca12 - 99 commits from branch master
• a16a8e03 - Streamline MagneticField handling

Compare with previous version

I've aborted the test I had just launched. Should I relaunch one or do you have more changes to push ?

resolved all threads

resolved all threads

/ci-test

added 17 commits

• a16a8e03...2c0a3979 - 16 commits from branch master
• 9a6297fe - Streamline MagneticField handling

Compare with previous version

resolved all threads

/ci-test

@gcorti @mexu Do you need a specific ci test for simulation here ?

/ci-test --model lhcb-sim11

marked the checklist item RTA as completed

marked the checklist item Simulation as completed

added 25 commits

• 9a6297fe...13c4bdc8 - 24 commits from branch master
• 6bcadce0 - Streamline MagneticField handling

Compare with previous version

ping -- it seems this MR has been forgotten, so I spent the last 10 min or so to fixing the fall-out of the formatting changes. Would have been nice if this had been merged prior to that.

added 1 commit

• a20f3891 - Streamline MagneticField handling

Compare with previous version

added 3 commits

• a20f3891...e32aa7ab - 2 commits from branch master
• e04318e2 - Streamline MagneticField handling

Compare with previous version

marked the checklist item Core Software as completed

approved this merge request

/ci-test

/ci-test --model lhcb-sim11

resolved all threads

added 5 commits

• e04318e2...13c2b085 - 4 commits from branch master
• 7cbd4a12 - Streamline MagneticField handling

Compare with previous version

resolved all threads

merged

mentioned in commit ac6b0e3c